[build] remove examples/build.zig, incorporate into main build.zig #4856
+103
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the second build.zig in the examples directory and incorporates it into the main build.zig. This gives the zig build system the data needed to know if the raylib library needs to be rebuilt when running any example.
|
@marler8997 Great! Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different way to solve the same issue that #4854 solves. That PR keeps the examples build separate and connects it to the raylib build via a zon file, this PR instead removes the second build.zig in the examples directory and incorporates it into the main build.zig.
My personal preference would be this PR but both solve the underlying issue.
Note that running
zig buildwill still only build the raylib library, I've added a separateexamplestarget that will build all the examples (what runningzig buildin the examples directory would have done before).NOTE: I also updated the examples build configuration so that we only add the extra include paths for the examples that need it.