Guard against DEBUG Redefinition #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undefine DEBUG to avoid external redefinition warnings/conflicts. This is probably a common definition for many external build systems' debug configurations. This ensures raylib will not emit a warning about the DEBUG definition being redefined in external build systems.
|
Oops, had some extra whitespace in the commit. I fixed it. Don't need extra changes in the git history, hehe. |
|
@NiamhNightglow thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an #undef DEBUG before the DEBUG(...) macro definition in jar_xm.h to prevent redefinition warnings and potential conflicts. This macro is commonly defined by external build systems for debug configurations, so undefining it here avoids collisions without disrupting other code.
I also looked and jar_xm.h seems to only be included in raudio.c as an implementation detail, so I don't believe this should affect anything else(and if anything does include jar_xm.h directly, it was almost certainly getting redefined anyway)
This should help clean up some pesky warnings in debug builds so people can turn on -Werror to enforce clean builds, even if they define DEBUG elsewhere or pass -DDEBUG as a compiler option.