-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rcore][RGFW] Add new backend option: PLATFORM_WEB_RGFW
and update RGFW
#4480
base: master
Are you sure you want to change the base?
Conversation
Issues thus far:
|
@ColleagueRiley Thank you very much for working on this new platform backend! Exiting to have a GLFW alternative for |
PLATFORM_WEB_RGFW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raysan5 @ColleagueRiley
Is it still the raylib practice not to modify externals since the latest ones upstream are included at each release?
Is an exception being made to maintain RGFW.h
under raylib?
Musing: The platforms changes setup is intriguing. I am not quite clear how one deals with maintenance and confirmation across them, especially with raylib changes that impact rcore.c
. Not my problem, but something that catches my eye.
@raysan5 The only remaining issue with the web platform is the fullscreen toggle. |
PLATFORM_WEB_RGFW
PLATFORM_WEB_RGFW
and update RGFW
@ColleagueRiley I've been reviewing this PR. Some concerns:
Thinking about the best way to add this new Web platform backend option to minimize friction... no need to change anything for now (beside the formating details). |
@raysan5 In my opinion the current approach is already pretty simply, an alternative could be to define a variable like |
@raysan5 I fixed the formatting issues I found, let me know if I'm missing anything. |
Adds
PLATFORM_WEB_RGFW
and updates RGFWRGFW Updates: