Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rcore][RGFW] Add new backend option: PLATFORM_WEB_RGFW and update RGFW #4480

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ColleagueRiley
Copy link
Contributor

@ColleagueRiley ColleagueRiley commented Nov 10, 2024

Adds PLATFORM_WEB_RGFW and updates RGFW

RGFW Updates:

  • fix bugs and refine gamepad support, and rename joystick to gamepad (X11) (WinAPI) (HTML5)
  • fix window resize bug (X11)
  • fix use of ctypes (Visual Studio)
  • Fix warnings

@ColleagueRiley ColleagueRiley marked this pull request as draft November 10, 2024 22:59
@ColleagueRiley
Copy link
Contributor Author

ColleagueRiley commented Nov 10, 2024

Issues thus far:

  • Fullscreen toggle causing screen to go black

  • more testing has to be done

@raysan5
Copy link
Owner

raysan5 commented Nov 14, 2024

@ColleagueRiley Thank you very much for working on this new platform backend! Exiting to have a GLFW alternative for PLATFORM_WEB! Keep up the great work!

@raysan5 raysan5 changed the title Add PLATFORM_WEB_RGFW [rcore][RGFW] Add new backend option: PLATFORM_WEB_RGFW Nov 16, 2024
Copy link
Contributor

@orcmid orcmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raysan5 @ColleagueRiley
Is it still the raylib practice not to modify externals since the latest ones upstream are included at each release?

Is an exception being made to maintain RGFW.h under raylib?

Musing: The platforms changes setup is intriguing. I am not quite clear how one deals with maintenance and confirmation across them, especially with raylib changes that impact rcore.c. Not my problem, but something that catches my eye.

@ColleagueRiley
Copy link
Contributor Author

ColleagueRiley commented Nov 21, 2024

@raysan5 The only remaining issue with the web platform is the fullscreen toggle.

@ColleagueRiley ColleagueRiley marked this pull request as ready for review November 25, 2024 11:51
Makefile Outdated Show resolved Hide resolved
@ColleagueRiley ColleagueRiley changed the title [rcore][RGFW] Add new backend option: PLATFORM_WEB_RGFW [rcore][RGFW] Add new backend option: PLATFORM_WEB_RGFW and update RGFW Nov 28, 2024
@raysan5
Copy link
Owner

raysan5 commented Dec 11, 2024

@ColleagueRiley I've been reviewing this PR. Some concerns:

  • I see now we have PLATFORM_WEB (defaults to GLFW) and PLATFORM_WEB_RGFW. I'm thinking if the currrent approach with the filters in Makefile can be somewhat simplified in some way... maybe not... just thinking...
  • There are several formating detailes in the PR, not following raylib coding conventions, including some TABs.

Thinking about the best way to add this new Web platform backend option to minimize friction... no need to change anything for now (beside the formating details).

@ColleagueRiley
Copy link
Contributor Author

@raysan5 In my opinion the current approach is already pretty simply, an alternative could be to define a variable like USES_WEB when PLATFORM_WEB or PLATFORM_WEB_RGFW is defined and use that instead of checking for PLATFORM_WEB or PLATFORM_WEB_RGFW each time. Although I don't think that way is necessarily better or worse, it's just up to how you want it to be formatted.

@ColleagueRiley
Copy link
Contributor Author

@raysan5 I fixed the formatting issues I found, let me know if I'm missing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants