Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.zig: Re-add OpenGL to Linux deps #4417

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

sagehane
Copy link
Contributor

Of course, being dumb, I forgot to test the damn thing with an actual binary and got hit by missing OpenGL issues at runtime. Sigh

@raysan5 raysan5 merged commit 55249fa into raysan5:master Oct 22, 2024
2 checks passed
@raysan5
Copy link
Owner

raysan5 commented Oct 22, 2024

@sagehane Thanks for the update... please, note that I'm not testing all those changes and a new raylib release is around the corner, build.zig should be as much stable as possible...

@sagehane
Copy link
Contributor Author

sagehane commented Oct 22, 2024

I'm very sorry about all the sloppiness on my part. AFAIK, there is one more bug with the build system at #4407 (review) and that should be everything. I'll extract that to a separate PR and focus on reviewing the PRs more carefully and understanding this repo until the next release. Everything else would classify as enhancements over the existing setup and wouldn't be required. Aside from that, the fact that I haven't been able to check how Raygui works with the current build system is slightly concerning, but I don't think I would have introduced breaking errors.

psxdev pushed a commit to raylib4Consoles/raylib that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants