[rshapes] Make sure DrawRectangleLinesEx accounts for square tiles #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joshalosh
changed the title
Joshalosh
changed the title
|
@Joshalosh oh! Good catch! Thanks for the review! |
|
You're very welcome :) |
psxdev
pushed a commit
to raylib4Consoles/raylib
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the thickness is greater than the width or the height a comparison between the rec.width and rec.height is made. The line thickness then becomes half of whatever is smaller. At the moment this doesn't account for if the rec.width and rec.height are equal. Which could potentially be pretty common for people making tile-based games. ( I accidentally ran into this )