Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples][shaders_raymarching] Add raymarching.fs for GLSL120 #4183

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

CDM15y
Copy link
Contributor

@CDM15y CDM15y commented Jul 26, 2024

Raymarching example shader ported to glsl 1.20, and tested on Intel Mobile 4 Series Chipset Integrated Graphics Controller

@raysan5 raysan5 changed the title [EXAMPLES] Add raymarching.fs [examples][shaders_raymarching] Add raymarching.fs for GLSL120 Jul 27, 2024
@CDM15y
Copy link
Contributor Author

CDM15y commented Jul 29, 2024

title change and no pull?

@raysan5
Copy link
Owner

raysan5 commented Jul 29, 2024

@CDM15y pull requires verification and validation. And it requires time.

@raysan5
Copy link
Owner

raysan5 commented Jul 30, 2024

@CDM15y Added some review comments.

@raysan5
Copy link
Owner

raysan5 commented Aug 4, 2024

I'm afraid I'm closing this PR, no reviews have been made.

@raysan5 raysan5 closed this Aug 4, 2024
@CDM15y
Copy link
Contributor Author

CDM15y commented Aug 4, 2024

@raysan5 What do you mean by reviews? sorry, I'm a beginner to pull requests and Github in general.
This is just the GLSL 330 shader, modified to work on GLSL 120 for desktop GL to work on Raspberry Pi and old PCs.

@raysan5
Copy link
Owner

raysan5 commented Aug 5, 2024

@CDM15y Some reviews were requested, the changes should be added as additional commits to this PR but were not, in any case, this file is almost the same as glsl100 version, only 2 lines change

@CDM15y
Copy link
Contributor Author

CDM15y commented Aug 5, 2024

I didn't realize there was a glsl100 version, this was based off the 330 version. should I reopen a pull request and add the changes as additional commits?

@raysan5 raysan5 reopened this Aug 5, 2024
@raysan5
Copy link
Owner

raysan5 commented Aug 5, 2024

@CDM15y ok, reopened 🙂

Copy link
Contributor Author

@CDM15y CDM15y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#version 120 is correctly specified for GLSL 120.

use varying and attribute instead of in and out to match GLSL 120 syntax.

use gl_FragColor instead fragColor to to match GLSL 120 standards.

Moved the license to the top of the code to improve readability.

Remove `fragColor` as it is unused

Move the license to the top of the code to improve readability.
@raysan5 raysan5 merged commit b44b759 into raysan5:master Aug 6, 2024
14 checks passed
@raysan5
Copy link
Owner

raysan5 commented Aug 6, 2024

@CDM15y thanks for the addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants