-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples][shaders_raymarching] Add raymarching.fs
for GLSL120
#4183
Conversation
raymarching.fs
for GLSL120
title change and no pull? |
@CDM15y pull requires verification and validation. And it requires time. |
@CDM15y Added some review comments. |
I'm afraid I'm closing this PR, no reviews have been made. |
@raysan5 What do you mean by reviews? sorry, I'm a beginner to pull requests and Github in general. |
@CDM15y Some reviews were requested, the changes should be added as additional commits to this PR but were not, in any case, this file is almost the same as glsl100 version, only 2 lines change |
I didn't realize there was a glsl100 version, this was based off the 330 version. should I reopen a pull request and add the changes as additional commits? |
@CDM15y ok, reopened 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#version 120
is correctly specified for GLSL 120.
use varying
and attribute
instead of in and out to match GLSL 120 syntax.
use gl_FragColor
instead fragColor
to to match GLSL 120 standards.
Moved the license to the top of the code to improve readability.
Remove `fragColor` as it is unused Move the license to the top of the code to improve readability.
@CDM15y thanks for the addition |
Raymarching example shader ported to glsl 1.20, and tested on
Intel Mobile 4 Series Chipset Integrated Graphics Controller