Update RGFW #4176
Merged
Update RGFW #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ColleagueRiley Thanks for the update! |
raysan5
reviewed
Jul 22, 2024
| CORE.Window.display.width = screenSize.w; | ||
| CORE.Window.display.height = screenSize.h; | ||
| /* | ||
| I think this is needed by Raylib now ? |
There was a problem hiding this comment.
I saw it in the glfw platform, I'm not sure if it's an init function Raylib requires or not.
raysan5
reviewed
Jul 22, 2024
| @@ -643,7 +645,7 @@ Vector2 GetWindowScaleDPI(void) | |||
| { | |||
| RGFW_monitor monitor = RGFW_window_getMonitor(platform.window); | |||
|
|
|||
| return (Vector2){((u32)monitor.scaleX)*platform.window->r.w, ((u32) monitor.scaleX)*platform.window->r.h}; | |||
| return (Vector2){monitor.scaleX, monitor.scaleX}; | |||
There was a problem hiding this comment.
Not following raylib coding conventions, a space after { and before } should be used
| @@ -483,14 +483,14 @@ void SetWindowIcons(Image *images, int count) | |||
| // Set title for window | |||
| void SetWindowTitle(const char *title) | |||
| { | |||
| RGFW_window_setName(platform.window, title); | |||
| RGFW_window_setName(platform.window, (char*)title); | |||
There was a problem hiding this comment.
Not following raylib coding conventions, raylib uses (char *)
| // Set cursor position in the middle | ||
| SetMousePosition(CORE.Window.screen.width/2, CORE.Window.screen.height/2); | ||
|
|
||
| RGFW_window_mouseHold(platform.window, RGFW_AREA(CORE.Window.screen.width / 2, CORE.Window.screen.height / 2)); |
There was a problem hiding this comment.
Not following raylib coding conventions, raylib does not use spaces between * and / operators
|
Added some minor formatting comments, no worries, I can review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of updates and bug fixes for RGFW and rcore_desktio_RGFW.c