Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtextures] advance k in LoadImageColors #4120

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

brccabral
Copy link
Contributor

Some formats are not advancing k to get pixels values

Some formats are not advancing k to get pixels values
@raysan5 raysan5 merged commit b5473d5 into raysan5:master Jul 1, 2024
14 checks passed
@raysan5
Copy link
Owner

raysan5 commented Jul 1, 2024

@brccabral Thanks for the review!

SIDE NOTE: I added a TODO with a possible improvement: instead of always returning PIXELFORMAT_UNCOMPRESSED_GRAYSCALE, it could return other single-channel formats like PIXELFORMAT_UNCOMPRESSED_R16 and PIXELFORMAT_UNCOMPRESSED_R32 when the image provided to extract channel is a 16bit/channel or 32bit/channel data. So, no data is lost in those cases (and it's up to the user to convert them to lower resolution if desired).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants