Update RGFW and replace long switch in rcore_desktop_rgfw.c with a lookup table #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why this claims there were 13 commits 😅 |
raysan5
reviewed
Jun 27, 2024
|
It should be good now 👍 |
|
@ColleagueRiley Nice! Thanks for the improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got around to writing a proper abstraction for keycodes for RGFW. This PR includes that and many quality updates/fixes RGFW.
JeffM commented on how
rcore_desktop_rgfw.cuses a long switch for converting keycodes. That's not great for performance, this PR replaces it with a lookup table.