[rmodels] LoadBoneInfoGLTF(), add check for animation name being NULL
#4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raysan5
reviewed
Jun 10, 2024
src/rmodels.c
Outdated
| @@ -4864,7 +4864,9 @@ static BoneInfo *LoadBoneInfoGLTF(cgltf_skin skin, int *boneCount) | |||
| for (unsigned int i = 0; i < skin.joints_count; i++) | |||
| { | |||
| cgltf_node node = *skin.joints[i]; | |||
| strncpy(bones[i].name, node.name, sizeof(bones[i].name)); | |||
| if (node.name != NULL) { | |||
There was a problem hiding this comment.
Please, could you avoid the brackets, in raylib one line statements use no-brackets:
if (node.name != NULL) strncpy(bones[i].name, node.name, sizeof(bones[i].name));
There was a problem hiding this comment.
Done! And sorry, I missed this code convention!
raysan5
changed the title
LoadBoneInfoGLTF(), add check for animation name being NULL
4 tasks
VitoTringolo
force-pushed
the
gltf-bone-null-check
branch
from
a5224f6 to
00d7e8c
Compare
|
@VitoTringolo thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue described here #4037 with this model https://github.com/KhronosGroup/glTF-Sample-Models/blob/main/2.0/BrainStem/glTF-Binary/BrainStem.glb