fix(cmake): infer CMAKE_MODULE_PATH in super-build #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fruzitent thanks for the review! Please note that I do not maintain the CMake build system, in case this PR results in some unexpected behaviour, it is not tested by me. |
JayLCypher
pushed a commit
to JayLCypher/raylib
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raylib as a library should not override the
CMAKE_MODULE_PATHvariable. This is the way it is used in glfw.As it also depends on
find_package()calls which expect system-wide installed dependencies, this prevents you from using customFind<target>.cmakefiles to build them in-source.In CMake this is a bit hacky, but in e.g. meson this is natively supported behavior.