Fix #3891 breaking builds for Zig v0.11.0 #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes brought by raysan5#3891 uses `std.process.Child.run` which was renamed from `std.process.Child.exec` in Zig version 0.11.0. This commit adds a version check to use the appropriate function names. Additionally, the `linux_display_backend` configuration option is added so users can set it when running `zig build` with the `-D` option or when using raylib as a dependency.
|
@iarkn thanks for the review! |
|
Thank @iarkn completely missed that on my pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes brought by #3891 uses
std.process.Child.runwhich was renamed fromstd.process.Child.execin Zig version 0.11.0, resulting in an error when trying to build raylib with Zig version 0.11.0. This commit adds a version check to use the appropriate function names.Additionally, the
linux_display_backendconfiguration option is added so users can set it when runningzig buildwith the-Doption or when using raylib as a dependency.Tested with Zig version
0.11.0and version0.12.0-dev.3522+b88ae8dbd.Resolves #3895.