Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed coding style in function TextToFloat #3627

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

benjibst
Copy link
Contributor

No description provided.

@raysan5 raysan5 merged commit 6083d2b into raysan5:master Dec 13, 2023
@raysan5
Copy link
Owner

raysan5 commented Dec 13, 2023

@benjibst thanks for the addition and review!

@@ -1481,6 +1481,7 @@ RLAPI const char *TextToUpper(const char *text); // Get upp
RLAPI const char *TextToLower(const char *text); // Get lower case version of provided string
RLAPI const char *TextToPascal(const char *text); // Get Pascal case notation version of provided string
RLAPI int TextToInteger(const char *text); // Get integer value from text (negative values not supported)
RLAPI float TextToFloat(const char *text); // Get float value from text (negative values not supported)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure: are those "negative values not supported" true as of now? Because the code seems to handle the minus sign just fine both in integer and floating point cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn i mustve copied the line without modifying the comments... ill fix that too. The function works for negative numbers too

denysmaistruk pushed a commit to denysmaistruk/raylib that referenced this pull request Dec 14, 2023
* function to convert string to float

* fix code to match coding conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants