Fix SDL keyboard issue #3435
Merged
Fix SDL keyboard issue #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have added a mapping table between raylib keys and SDL scancodes.
|
Tested successfully on Linux (Ubuntu 22.04 64-bit, gcc 11.2.0) with SDL2 (2.28.4). Great job! |
|
@Bigfoot71 Nice! Thanks for the improvement! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally mentioned by @ubkp in the issue [core] Splitting rcore by platform into submodules, here is the fix for the keyboard handling issue with SDL.
This modification includes a mapping table between SDL scancodes and raylib keys, along with a function to safely retrieve them.
I've also revised the state change of
CORE.Window.shouldCloseby usingCORE.Input.Keyboard.exitKeyinstead ofSDLK_ESCAPEdirectly, but as indicated in the comment, I believe this part would be better placed outside of the switch statement.