[raudio] Rewritten ExportWaveAsCode() file saving to be more like rtextures ExportImageAsCode()
#3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review `raudio.c`: rewritten `ExportWaveAsCode()` to be more like rtextures.c `ExportImageAsCode()'
accidentally inserted a tab somewhere. corrected it.
|
@RadsammyT Thanks for the review! :) |
futureapricot
pushed a commit
to futureapricot/raylib
that referenced
this pull request
Oct 4, 2023
…textures `ExportImageAsCode()` (raysan5#3013) * Update raudio.c Review `raudio.c`: rewritten `ExportWaveAsCode()` to be more like rtextures.c `ExportImageAsCode()' * no tab november accidentally inserted a tab somewhere. corrected it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
ExportWaveAsCode()has some various bugs/inconsistencies:The data array name will list the entire path to the file. I don't know if ':', '/', and '\' are valid symbols in C var names but I made it so only the file name without its path and extension are listed. Also, note the missing file names before the wave data information preprocessor defines, and the unusual data array var name casing.
Before:
After:
