Fixed some grammar mistakes and typos. #2914
Conversation
| @@ -2319,7 +2319,7 @@ static ma_uint32 ReadAudioBufferFramesInInternalFormat(AudioBuffer *audioBuffer, | |||
| { | |||
| // We break from this loop differently depending on the buffer's usage | |||
| // - For static buffers, we simply fill as much data as we can | |||
| // - For streaming buffers we only fill the halves of the buffer that are processed | |||
There was a problem hiding this comment.
raudio.c line 2322: I am unclear on what change captures the intended sense here. I think it is "a half of the buffer that is processed." That might mean both haves in sequence when the buffer has been completely drained.
| @@ -5456,7 +5456,7 @@ static void MouseButtonCallback(GLFWwindow *window, int button, int action, int | |||
| gestureEvent.position[0].x /= (float)GetScreenWidth(); | |||
| gestureEvent.position[0].y /= (float)GetScreenHeight(); | |||
|
|
|||
| // Gesture data is sent to gestures system for processing | |||
| // Gesture data is sent to gestures-system for processing | |||
There was a problem hiding this comment.
rcore.c line 5459: The original seems correct. It is not used as an adjective as gestures-system would be.
same for line 5490.
There was a problem hiding this comment.
In that case it should not have s in gestures...
There was a problem hiding this comment.
That does sound better. Is it accurate?
| @@ -978,7 +978,7 @@ void DrawRectangleRounded(Rectangle rec, float roundness, int segments, Color co | |||
| rlSetTexture(texShapes.id); | |||
|
|
|||
| rlBegin(RL_QUADS); | |||
| // Draw all of the 4 corners: [1] Upper Left Corner, [3] Upper Right Corner, [5] Lower Right Corner, [7] Lower Left Corner | |||
| // Draw all the 4 corners: [1] Upper Left Corner, [3] Upper Right Corner, [5] Lower Right Corner, [7] Lower Left Corner | |||
There was a problem hiding this comment.
shapes.c line 981 or just day "Draw the 4 corners: ..."
Also lines 1210, 1345
| @@ -647,7 +647,7 @@ GlyphInfo *LoadFontData(const unsigned char *fileData, int dataSize, int fontSiz | |||
| } | |||
| } | |||
|
|
|||
| // Get bounding box for character (may be offset to account for chars that dip above or below the line) | |||
| // Get bounding box for character (maybe offset to account for chars that dip above or below the line) | |||
There was a problem hiding this comment.
rtext.c line 650: Is it safe to say "(will be offset ..." ?
There was a problem hiding this comment.
On seconds thoughts it should be used might... Wouldn't it fit better?
|
Well-done. This is more manageable. I have fewer comments and some may be coin-flips. Ramon's review will determine what's important enough to him. |
|
Yes, hope this helps. I still hava a pull request regarding a buffer too small for that data stored. I'll check it soon and some other things I noticed so you can review it. |
Update rl_gputex.h Added raymarch example and thumbnail for write depth (raysan5#2919) Fixed some grammar mistakes and typos. (raysan5#2914) * Fixed some grammar mistakes. * Fixed some typos. Update raylib-hx bindings to 4.2 in BINDINGS.md (raysan5#2916) Enable GetWindowHandle() on macOS (raysan5#2915)
As asked, I made fewer commits in this pull request. I will keep reviewing the project... And adding what I found in time. Let me know about your revision.