-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[models] Add GLTF animation support #2844
Conversation
Oh, I should also add an example for this. I'll update |
Updated the .blend file to use weights rather than bone parents so it fits into the framework. Exported with weights to the .glb file.
Updated the |
@charles-l Hey! This is an amazing addition, waiting for it for some time! I like the implementation, quite self-contained, just let me know when you think it's final and I'll merge and review it properly. Thanks for this great improvement! |
Great, sounds good! I made a few final small tweaks, and it should be ready to go now. Let me know if there are any improvements or changes I should make! BTW, I had a lot of fun working on this codebase. It's so easy to get started when there aren't layers upon layers of abstractions concealing what's really going on. I haven't written much in this style of C before (spartan data structure choice, pre-allocation as much as possible, etc), but really enjoyed it. Kudos on an awesome framework :) |
@charles-l Please, could you review code formating to follow raylib coding conventions? |
ok! Updated the PR with fixed formatting. |
@charles-l Just reviewed the code and there are still some formatting issues, please, could you review them? |
Fixed brace alignment and removed asserts. |
@charles-l Merged! Thank you very much for this nice improvement! 😄 |
I needed GLTF animation support for my project, but I noticed that Raylib has added and removed support for it in the past. If this isn't really in the scope for the project, I'd be happy to pull this out into a plugin or helper library (but I figured I'd submit a PR in case there was interest in including it).
Caveats:
translation
/rotation
/scale
animation channel.path support. I skippedweights
(i.e. morph targets).