Update build.zig to work with last GLFW update #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@realtradam Thanks for the review! Actually there is a related open issue! Where should the |
Ah I see, just read through that issue. I don't think I have enough experience here to give any useful advice that wouldn't just be guessing. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent GLFW update(9e0e08c) made build.zig no longer work. It would fail compilation by saying that
ppoll()was undeclared. Adding the-D_GNU_SOURCEflag to compilation fixes this issue(same fix as this one done on the Makefile: be2328f).This change was tested and works on Linux(Artix), I have not tested on Windows or MacOS as I do not have either of those platforms.