Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Please allow to use the pre-installed external glfw #453

Closed
yurivict opened this issue Feb 2, 2018 · 7 comments
Closed

[build] Please allow to use the pre-installed external glfw #453

yurivict opened this issue Feb 2, 2018 · 7 comments

Comments

@yurivict
Copy link
Contributor

yurivict commented Feb 2, 2018

No description provided.

@yurivict
Copy link
Contributor Author

yurivict commented Feb 2, 2018

There is also no need for find_package(OpenGL REQUIRED) when external glfw package is used.

a3f added a commit to a3f/raylib that referenced this issue Feb 3, 2018
@a3f
CMake: Add tristate option for using system GLFW
d7ac2a6 
-DWITH_SYSTEM_GLFW=ON: Link against system glfw and fail otherwise
-DWITH_SYSTEM_GLFW=OFF: Use embedded rglfw.c
-DWITH_SYSTEM_GLFW=IF_POSSIBLE: Probe for system glfw but fallback to
                                rglfw if unavailable

Also change Linux 64-bit build to install system glfw and use it,
so this doesn't bitrot.

Addresses raysan5#453.
a3f added a commit to a3f/raylib that referenced this issue Feb 3, 2018
@a3f
CMake: Add tristate option for using system GLFW
59b0156 
-DWITH_SYSTEM_GLFW=ON: Link against system glfw and fail otherwise
-DWITH_SYSTEM_GLFW=OFF: Use embedded rglfw.c
-DWITH_SYSTEM_GLFW=IF_POSSIBLE: Probe for system glfw but fallback to
                                rglfw if unavailable

Also change Linux 64-bit build to install system glfw and use it,
so this doesn't bitrot.

Addresses raysan5#453.
a3f added a commit that referenced this issue Feb 3, 2018
@a3f
CMake: Add tristate option for using system GLFW (#455)
7f5fa4d 
-DWITH_SYSTEM_GLFW=ON: Link against system glfw and fail otherwise
-DWITH_SYSTEM_GLFW=OFF: Use embedded rglfw.c
-DWITH_SYSTEM_GLFW=IF_POSSIBLE: Probe for system glfw but fallback to
                                rglfw if unavailable

Also change Linux 64-bit CI build to install system glfw and use it,
so this doesn't bitrot.

Addresses #453.
@a3f
Copy link
Contributor

a3f commented Feb 3, 2018

You may now pass -DWITH_SYSTEM_GLFW=ON to CMake.

@raysan5
Copy link
Owner

raysan5 commented Feb 3, 2018 •
edited
Loading

Current Makefile already allows using external GLFW.

@raysan5 raysan5 changed the title Please allow to use the pre-installed external glfw [build] Please allow to use the pre-installed external glfw Feb 3, 2018
@raysan5
Copy link
Owner

raysan5 commented Feb 4, 2018

@a3f would it be possible to rename option to USE_EXTERNAL_GLFW for consistency with current Makefile?

@raysan5 raysan5 mentioned this issue Feb 4, 2018
Closed
10 tasks
a3f added a commit that referenced this issue Feb 4, 2018
@a3f
CMake: Rename WITH_SYSTEM_GLFW to USE_EXTERNAL_GLFW
cb66c89 
for consistency with Makefile. Requested by @raysan5 in #453.
@raysan5
Copy link
Owner

raysan5 commented Feb 4, 2018

Thanks @a3f!

@raysan5
Copy link
Owner

raysan5 commented Feb 11, 2018

Could this bug be closed?

@Martinfx
Copy link
Contributor

yes

@a3f a3f closed this as completed Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yurivict @Martinfx @a3f @raysan5