WARNING: DrawLineBezier() implementation needs review #2721

raysan5 · Oct 2, 2022 · 33e7f7c · 33e7f7c
1 parent 0daaadd
commit 33e7f7c
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/rshapes.c b/src/rshapes.c
@@ -175,6 +175,8 @@ void DrawLineBezier(Vector2 startPos, Vector2 endPos, float thick, Color color)
         current.y = EaseCubicInOut((float)i, startPos.y, endPos.y - startPos.y, (float)BEZIER_LINE_DIVISIONS);
         current.x = previous.x + (endPos.x - startPos.x)/ (float)BEZIER_LINE_DIVISIONS;
 
+        // TODO: Avoid drawing the line by pieces, it generates gaps for big thicks,
+        // Custom "triangle-strip" implementation should be used, check DrawTriangleStrip() for reference
         DrawLineEx(previous, current, thick, color);
 
         previous = current;
@@ -201,6 +203,8 @@ void DrawLineBezierQuad(Vector2 startPos, Vector2 endPos, Vector2 controlPos, fl
         current.y = a*startPos.y + b*controlPos.y + c*endPos.y;
         current.x = a*startPos.x + b*controlPos.x + c*endPos.x;
 
+        // TODO: Avoid drawing the line by pieces, it generates gaps for big thicks,
+        // Custom "triangle-strip" implementation should be used, check DrawTriangleStrip() for reference
         DrawLineEx(previous, current, thick, color);
 
         previous = current;
@@ -227,6 +231,8 @@ void DrawLineBezierCubic(Vector2 startPos, Vector2 endPos, Vector2 startControlP
         current.y = a*startPos.y + b*startControlPos.y + c*endControlPos.y + d*endPos.y;
         current.x = a*startPos.x + b*startControlPos.x + c*endControlPos.x + d*endPos.x;
 
+        // TODO: Avoid drawing the line by pieces, it generates gaps for big thicks,
+        // Custom "triangle-strip" implementation should be used, check DrawTriangleStrip() for reference
         DrawLineEx(previous, current, thick, color);
 
         previous = current;