Rust 1.26 and assorted cleanups #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simpler code means less for LLVM to prune -> faster compilation. Also, use `eprintln!` for stderr when enabled, rather than stdout.
cuviper
changed the title
|
We merged RFC 3, and @nikomatsakis said, "I'm good with merging #656", so... bors r=nikomatsakis |
bors bot
added a commit
that referenced
this pull request
May 8, 2019
656: Rust 1.26 and assorted cleanups r=nikomatsakis a=cuviper In anticipation of [RFC 3](rayon-rs/rfcs#3), giving us a policy to soon raise our minimum to Rust 1.26, I started this branch to make the conversion. After the primary motivation of upgrading crossbeam, I also looked for ways to use newer language features. Throughout all of this, the public API should be completely unaffected. Closes #586 for newer crossbeam, even though we're not quite at the *newest*. Co-authored-by: Josh Stone <[email protected]>
Build failed |
|
bors r=nikomatsakis |
bors bot
added a commit
that referenced
this pull request
May 8, 2019
656: Rust 1.26 and assorted cleanups r=nikomatsakis a=cuviper In anticipation of [RFC 3](rayon-rs/rfcs#3), giving us a policy to soon raise our minimum to Rust 1.26, I started this branch to make the conversion. After the primary motivation of upgrading crossbeam, I also looked for ways to use newer language features. Throughout all of this, the public API should be completely unaffected. Closes #586 for newer crossbeam, even though we're not quite at the *newest*. Co-authored-by: Josh Stone <[email protected]>
This was referenced May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of RFC 3, giving us a policy to soon raise our minimum to Rust 1.26, I started this branch to make the conversion. After the primary motivation of upgrading crossbeam, I also looked for ways to use newer language features.
Throughout all of this, the public API should be completely unaffected.
Closes #586 for newer crossbeam, even though we're not quite at the newest.