Add a fallback when threading is unsupported #1019
Conversation
|
Thank you so much for working on this! I tested this out, and it seems to be working exactly as advertised! I was a bit worried that using |
|
Could you avoid pulling Fallback to simple single-threaded execution without JS my primary use-case for the shim, and this compilation error gets in the way.
|
|
@kornelski we only have |
cuviper
force-pushed
the
unsupported-threads
branch
4 times, most recently
from
d9a4ca8
to
f060ff4
Compare
cuviper
force-pushed
the
unsupported-threads
branch
from
f060ff4
to
e3dd0a5
Compare
... even on "fallback" targets like `wasm32-wasi`!
|
bors try |
|
bors r+ |
|
Is there an ETA for when we will have a new |
|
I've queued up #1031 for tomorrow, if everything looks good. |
Now that rayon supports a fallback for non-threaded environments, see: rayon-rs/rayon#1019
|
In case anyone else runs across this -- the Officially, we released this in |
After seeing the issues with WASM that the last release (`0.5.0`) of this crate made, the idea is to now control the compatibility with WASM while at the same time, making it easy to handle. In this line of work, the idea was to simply do the following: - Use `rayon 1.8` as a dependency for paralellism which fixes the WASM compat issues with `multicore`-related things. See: rayon-rs/rayon#1019 thanks @han0110 for the suggestion. - Use conditional dev-dependency loading for `getrandom` such that we can compile the lib for WASM-targets in the CI without needing to have the dependency being pulled downstream. - The `multicore` module is gone, and the rest of the code has been refactored since the "fallback" is now handled by rayon itself.
* change: Move from `maybe_rayon` to `rayon-1.8` After seeing the issues with WASM that the last release (`0.5.0`) of this crate made, the idea is to now control the compatibility with WASM while at the same time, making it easy to handle. In this line of work, the idea was to simply do the following: - Use `rayon 1.8` as a dependency for paralellism which fixes the WASM compat issues with `multicore`-related things. See: rayon-rs/rayon#1019 thanks @han0110 for the suggestion. - Use conditional dev-dependency loading for `getrandom` such that we can compile the lib for WASM-targets in the CI without needing to have the dependency being pulled downstream. - The `multicore` module is gone, and the rest of the code has been refactored since the "fallback" is now handled by rayon itself. * change: Update CI to account for WASM compat * chore: Add paralellism section to README * chore: Fix CI missing " * chore: Split WASM build & add targets * chore: Test all features for regular-target builds * chore: Address review nits
…rations#122) * change: Move from `maybe_rayon` to `rayon-1.8` After seeing the issues with WASM that the last release (`0.5.0`) of this crate made, the idea is to now control the compatibility with WASM while at the same time, making it easy to handle. In this line of work, the idea was to simply do the following: - Use `rayon 1.8` as a dependency for paralellism which fixes the WASM compat issues with `multicore`-related things. See: rayon-rs/rayon#1019 thanks @han0110 for the suggestion. - Use conditional dev-dependency loading for `getrandom` such that we can compile the lib for WASM-targets in the CI without needing to have the dependency being pulled downstream. - The `multicore` module is gone, and the rest of the code has been refactored since the "fallback" is now handled by rayon itself. * change: Update CI to account for WASM compat * chore: Add paralellism section to README * chore: Fix CI missing " * chore: Split WASM build & add targets * chore: Test all features for regular-target builds * chore: Address review nits
…rations#122) * change: Move from `maybe_rayon` to `rayon-1.8` After seeing the issues with WASM that the last release (`0.5.0`) of this crate made, the idea is to now control the compatibility with WASM while at the same time, making it easy to handle. In this line of work, the idea was to simply do the following: - Use `rayon 1.8` as a dependency for paralellism which fixes the WASM compat issues with `multicore`-related things. See: rayon-rs/rayon#1019 thanks @han0110 for the suggestion. - Use conditional dev-dependency loading for `getrandom` such that we can compile the lib for WASM-targets in the CI without needing to have the dependency being pulled downstream. - The `multicore` module is gone, and the rest of the code has been refactored since the "fallback" is now handled by rayon itself. * change: Update CI to account for WASM compat * chore: Add paralellism section to README * chore: Fix CI missing " * chore: Split WASM build & add targets * chore: Test all features for regular-target builds * chore: Address review nits
Fixes #861.