Remove remaining future imports. #6825

sven1977 · 2020-01-18T07:37:39Z

Some 10+ future imports were not captured in previous PR.

I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://ray.readthedocs.io/en/latest/.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.

AmplabJenkins · 2020-01-18T07:44:29Z

Can one of the admins verify this patch?

AmplabJenkins · 2020-01-18T09:50:18Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20778/
Test FAILed.

…cess.py to give atexit more time to erase file.

AmplabJenkins · 2020-01-19T18:29:44Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20823/
Test FAILed.

edoakes

LGTM, please fix lint errors. You can run ./setup_hooks.sh to create a pre-push hook that runs the linter.

sven1977 · 2020-01-21T08:07:23Z

It's not LINT, it's some python 3.x incompatibility with the print(.., file=xyz) syntax. I'm taking a look.

sven1977 · 2020-01-21T08:09:51Z

So we are getting this here after we removed the remaining from __future__ import print:

Setting environment variables from .travis.yml
185$ export TESTSUITE=streaming
186$ export JDK='Oracle JDK 8'
187$ export RAY_INSTALL_JAVA=1
188$ export PYTHON=3.5
189$ export PYTHONWARNINGS=ignore
190
cache.1
191Setting up build cache
201
202$ bash -c 'echo $BASH_VERSION'
2034.3.48(1)-release
204
2050.05s$ python $TRAVIS_BUILD_DIR/ci/travis/determine_tests_to_run.py
206  File "/home/travis/build/ray-project/ray/ci/travis/determine_tests_to_run.py", line 46
207    print(pformat(files), file=sys.stderr)
208                              ^
209SyntaxError: invalid syntax
210The command "python $TRAVIS_BUILD_DIR/ci/travis/determine_tests_to_run.py" failed and exited with 1 during .

My guess is, we are still running the determine_tests_to_run.py with py2.

…s Travis test suite).

sven1977 · 2020-01-21T09:33:23Z

@edoakes
Yes, so apparently, somehow, it's still using py2. I don't know why, the PYTHON var is set to "3.5" for all travis tests.

$ python -V
Python 2.7.12

sven1977 · 2020-01-21T09:59:53Z

Travis does not respect the $PYTHON env variable. I printed out the actual py version used via python -V inside install_dependencies.sh and it's indeed py 2.7.12, even though the env variable is set to PYTHON=3.5 (<- that's the one we print out, but it's not the actual one!).
I also tried setting python:\n - "3.6" in the head of the .travis.yml file, but that doesn't help either.
Not sure what else to do at this point.

…n in travis.

…py3.5 checks in install-dependencies.sh, install-cython-examples.sh, install-ray.sh (vs py2.x <- no longer supported).

…all again from travis (will be done in install-dependencies.sh).

AmplabJenkins · 2020-01-21T11:48:30Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20901/
Test FAILed.

AmplabJenkins · 2020-01-21T12:01:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20902/
Test FAILed.

AmplabJenkins · 2020-01-21T12:18:54Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20903/
Test FAILed.

AmplabJenkins · 2020-01-21T12:25:28Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20893/
Test FAILed.

AmplabJenkins · 2020-01-21T12:28:19Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20904/
Test FAILed.

AmplabJenkins · 2020-01-21T12:42:34Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20905/
Test FAILed.

AmplabJenkins · 2020-01-21T12:47:59Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20894/
Test PASSed.

AmplabJenkins · 2020-01-21T13:22:42Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20896/
Test FAILed.

AmplabJenkins · 2020-01-21T13:39:14Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20897/
Test FAILed.

AmplabJenkins · 2020-01-21T13:42:03Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20899/
Test FAILed.

AmplabJenkins · 2020-01-21T13:49:47Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20892/
Test FAILed.

…pported by npm<=v5

AmplabJenkins · 2020-01-21T14:16:41Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20898/
Test PASSed.

AmplabJenkins · 2020-01-21T16:05:51Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20907/
Test FAILed.

AmplabJenkins · 2020-01-21T17:36:21Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20913/
Test FAILed.

AmplabJenkins · 2020-01-21T17:41:20Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20909/
Test FAILed.

AmplabJenkins · 2020-01-21T18:14:14Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20914/
Test FAILed.

AmplabJenkins · 2020-01-21T18:27:18Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20911/
Test PASSed.

AmplabJenkins · 2020-01-21T18:29:24Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20916/
Test FAILed.

AmplabJenkins · 2020-01-21T19:16:08Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/20908/
Test FAILed.

Remove remaining __future__ imports.

72b1a12

sven1977 marked this pull request as ready for review January 18, 2020 07:38

sven1977 requested a review from edoakes January 18, 2020 07:38

Attempt to increase sleep time from 5s to 10s in test_env_with_subpro…

0b5fb29

…cess.py to give atexit more time to erase file.

edoakes approved these changes Jan 20, 2020

View reviewed changes

sven1977 added 3 commits January 21, 2020 09:16

Move future print function back into determine_tests_to_run.py (break…

fad96fc

…s Travis test suite).

Set all envs in .travis.yml to PYTHON=3.5.

f8ea44c

python version test

854a526

sven1977 added 2 commits January 21, 2020 10:44

Test python 3.6 hint in .travis.yml file.

8b7d8e3

Print out actual py version in install-dependencies.sh

67f3d00

sven1977 added 6 commits January 21, 2020 11:07

Retire py version checks in travis-run sh scripts. Set language=pytho…

81c52a3

…n in travis.

Remove future import again from determine_tests_to_run.py.

4964f0f

Remove future import again from determine_tests_to_run.py.

583a50c

Move py3.5 definition to head of travis file and remove all obsolete …

c56fc50

…py3.5 checks in install-dependencies.sh, install-cython-examples.sh, install-ray.sh (vs py2.x <- no longer supported).

Add flake8 pip install to travis.

32ffc48

Rearrange if-blocks in install-dependencies.sh and remove flake8 inst…

114a813

…all again from travis (will be done in install-dependencies.sh).

sven1977 added 2 commits January 21, 2020 12:52

Fix xcode=7.3 in travis file.

f26ac0b

Update osx_image to 9.4.

b3de297

Test fix OSX build failure.

7c84420

Fix travis: python language for mac not supported.

d0b8a55

dont suppress install-ray output

6bcd400

print out npm version.

6ea61d8

Merge branch 'upstream_master' into remove_remaining_future_imports

5b6c13c

sven1977 added 3 commits January 21, 2020 14:53

Upgrade to latest npm version before using ci option, which is not su…

28f6056

…pported by npm<=v5

Move npm upgrade to before nvm.sh and nvm use node calls.

faf0912

Try to fix nvm vs npm version mismatch.

f492451

Printout npm nodejs versions.

4be3e3c

sven1977 closed this Jan 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove remaining future imports. #6825

Remove remaining future imports. #6825

sven1977 commented Jan 18, 2020 •

edited

Loading

AmplabJenkins commented Jan 18, 2020

AmplabJenkins commented Jan 18, 2020

AmplabJenkins commented Jan 19, 2020

edoakes left a comment

sven1977 commented Jan 21, 2020

sven1977 commented Jan 21, 2020

sven1977 commented Jan 21, 2020

sven1977 commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

Remove remaining __future__ imports. #6825

Remove remaining __future__ imports. #6825

Conversation

sven1977 commented Jan 18, 2020 • edited Loading

AmplabJenkins commented Jan 18, 2020

AmplabJenkins commented Jan 18, 2020

AmplabJenkins commented Jan 19, 2020

edoakes left a comment

Choose a reason for hiding this comment

sven1977 commented Jan 21, 2020

sven1977 commented Jan 21, 2020

sven1977 commented Jan 21, 2020

sven1977 commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

AmplabJenkins commented Jan 21, 2020

Remove remaining future imports. #6825

Remove remaining future imports. #6825

sven1977 commented Jan 18, 2020 •

edited

Loading