[ci] Relax Pydantic constraints#62308
Conversation
Signed-off-by: seiji <seiji@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various dependency lock files and requirements, including changes to Pydantic version constraints and the removal of several ML-related dependencies. The review highlights critical issues regarding the regression of Python version markers for core dependencies like cloudpickle, dask, distributed, and pandas, which were likely caused by compiling in a Python 3.12-only environment. Additionally, there are concerns regarding the removal of platform-specific markers for array-record, the potential invalidity of the xyzservices version, and a Pydantic version discrepancy introduced in the LLM requirements.
Signed-off-by: seiji <seiji@anyscale.com>
Signed-off-by: seiji <seiji@anyscale.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request relaxes the Pydantic version constraints in requirements.txt and setup.py to allow versions from 2.5.0 onwards and updates multiple dependencies, such as async-timeout, uvloop, and py-spy, across several lock files. Feedback indicates that the inline comment for the Pydantic dependency should be updated to clarify that both v1 and stable v2 versions are now supported. Additionally, the reviewer flagged unexpected downgrades of cloudpickle and pandas in the Python 3.12 lock files, suggesting that these should be reverted to their latest stable versions unless specific compatibility constraints necessitated the change.
eicherseiji
requested review from
aslonnie,
edoakes and
richardliaw
as code owners
|
@kouroshHakha ready to merge |
4 participants
Description
Relax the Pydantic version constraints introduced in [llm] upgrade vllm to 0.12.0 #58026, in particular, this diff:
https://github.com/ray-project/ray/pull/58026/changes?mode=single#diff-b72f6e5561c432513e240838ae1eeb3f85237fa3ed5d701ad4c3be2a55c57b9dR57
The base requirements-compiled.txt had locked pydantic==2.11 and vllm required 2.12, which is not taken into account when resolving requirements-compiled.txt in the CI step. Banning the intermediate Pydantic versions forced
requirements-compiled.txtto choosevllm==2.12.The constraint on Pydantic should have been removed before merging the PR and is no longer necessary