-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[deps][LLM] Upgrade vLLM to 0.15.0 #60253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cd095ee
758b2c9
923dabc
fc6b087
c1c11e7
d18c71c
52c45be
3190ad1
eca9898
24e1d99
231de88
04eb5d2
4cd9ecc
0d9957c
b749a9f
9f9958c
8248ad7
6711055
cda414a
3ae3f3e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ fi | |||
|
|
||||
| mkdir -p /tmp/ray-deps | ||||
|
|
||||
| # Remove the GPU constraints | ||||
| # Remove the GPU constraints, numpy, scipy, and pandas pin (vLLM 0.15.0+ requires numpy>=2, compatible scipy, and pandas>=2.0) | ||||
| cp "python/${FILENAME}" "/tmp/ray-deps/${FILENAME}" | ||||
| sed -e '/^--extra-index-url /d' -e '/^--find-links /d' "/tmp/ray-deps/${FILENAME}" > "/tmp/ray-deps/${FILENAME}.tmp" | ||||
| sed -e '/^--extra-index-url /d' -e '/^--find-links /d' -e '/^numpy==/d' -e '/^scipy==/d' -e '/^pandas==/d' "/tmp/ray-deps/${FILENAME}" > "/tmp/ray-deps/${FILENAME}.tmp" | ||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should not be here.. first, this is a generic file used not only for llm images, it is used for all images. this PR should not change how other images are built. second, the name of this file says "remove-compiled-headers". this is doing more than that. third, why not just upgrade? why do relaxing?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was trying to avoid from modifying this, but it seems like I'm actually touching something with broader impacts.
Do you think it's fine to upgrade this ^? |
||||
| mv "/tmp/ray-deps/${FILENAME}.tmp" "/tmp/ray-deps/${FILENAME}" | ||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linuxdefaults tomanylinux_2_28_x86_64which vllm 0.15.0 does not supportThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary.