[Core] Bump up object fetch timeout in release test #60016
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joshlee <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the object fetch timeout to 30 minutes for a release test that simulates transient network errors. This is a reasonable change to fix test flakiness. My feedback includes one suggestion to add a comment to the timeout value for better readability.
| - RAY_health_check_timeout_ms=100000 | ||
| - RAY_health_check_failure_threshold=10 | ||
| - RAY_gcs_rpc_server_connect_timeout_s=60 | ||
| - RAY_fetch_fail_timeout_milliseconds=1800000 |
Contributor
There was a problem hiding this comment.
For better readability and maintainability, consider adding a comment to clarify that this value represents 30 minutes. This helps other developers understand the value at a glance without having to perform the calculation.
- RAY_fetch_fail_timeout_milliseconds=1800000 # 30 minutes
ray-gardener
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object fetch's may take a while when in the presence of transient network errors due to long reconstruction chains + when push/pull fails we need to resend over all the chunks again. Hence we were seeing some ObjectFetchTimeout errors in the cross AZ transient network error release tests due to this, bumping up the timeout from 10 min to 30 min accordingly.