testing Revert "[5/n] IPv6 support: Add IPv6 localhost support and eliminate …

[ZacAttack]

…0.0.0.0 server bindings (#59852)"

This reverts commit 60bb749.

Thank you for contributing to Ray! 🚀
Please review the Ray Contribution Guide before opening a pull request.

⚠️ Remove these instructions before submitting your PR.

💡 Tip: Mark as draft if you want early feedback, or ready for review when it's complete.

Description

Briefly describe what this PR accomplishes and why it's needed.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

[gemini-code-assist]

Code Review

This pull request appears to be reverting recently added IPv6 support, falling back to IPv4-only logic in many parts of the codebase. The changes span across Python and C++ files, replacing dynamic IP address resolution with hardcoded IPv4 addresses.

My review focuses on the correctness and consistency of this revert. While the Python changes seem correct, I've identified a recurring critical issue in the C++ changes. The logic to determine if a server should bind to localhost is incomplete, as it only checks for "127.0.0.1" and misses the "localhost" hostname case. This could lead to servers unintentionally binding to all interfaces.

[gemini-code-assist]

This check for localhost is incomplete. It only checks for "127.0.0.1" and will fail if options.node_ip_address is "localhost". This would cause the gRPC server to incorrectly bind to all interfaces (0.0.0.0) instead of just localhost. To fix this, the check should also include "localhost".

Suggested change

	auto core_worker_server =
	std::make_unique<rpc::GrpcServer>(WorkerTypeString(options.worker_type),
	assigned_port,
	options.node_ip_address == "127.0.0.1");
	auto core_worker_server =
	std::make_unique<rpc::GrpcServer>(WorkerTypeString(options.worker_type),
	assigned_port,
	options.node_ip_address == "127.0.0.1" || options.node_ip_address == "localhost");

[gemini-code-assist]

This check for localhost is incomplete. It only checks for "127.0.0.1" and will fail if config.node_ip_address is "localhost". This would cause the gRPC server to incorrectly bind to all interfaces (0.0.0.0) instead of just localhost. To fix this, the check should also include "localhost".

Suggested change

	rpc_server_(config.grpc_server_name,
	config.grpc_server_port,
	config.node_ip_address,
	config.node_ip_address == "127.0.0.1",
	config.grpc_server_thread_num,
	/*keepalive_time_ms=*/RayConfig::instance().grpc_keepalive_time_ms()),
	rpc_server_(config.grpc_server_name,
	config.grpc_server_port,
	config.node_ip_address == "127.0.0.1" || config.node_ip_address == "localhost",
	config.grpc_server_thread_num,
	/*keepalive_time_ms=*/RayConfig::instance().grpc_keepalive_time_ms()),

[gemini-code-assist]

This check for localhost is incomplete. It only checks for "127.0.0.1" and will fail if config_.object_manager_address is "localhost". This would cause the server to incorrectly bind to all interfaces (0.0.0.0) instead of just localhost. To fix this, the check should also include "localhost".

Suggested change

	object_manager_server_("ObjectManager",
	config_.object_manager_port,
	config_.object_manager_address,
	config_.object_manager_address == "127.0.0.1",
	config_.rpc_service_threads_number),
	client_call_manager_(main_service,
	object_manager_server_("ObjectManager",
	config_.object_manager_port,
	config_.object_manager_address == "127.0.0.1" || config_.object_manager_address == "localhost",
	config_.rpc_service_threads_number),

[gemini-code-assist]

This check for localhost is incomplete. It only checks for "127.0.0.1" and will fail if config.node_manager_address is "localhost". This would cause the server to incorrectly bind to all interfaces (0.0.0.0) instead of just localhost. To fix this, the check should also include "localhost".

Suggested change

	node_manager_server_("NodeManager",
	config.node_manager_port,
	config.node_manager_address == "127.0.0.1"),
	node_manager_server_("NodeManager",
	config.node_manager_port,
	config.node_manager_address == "127.0.0.1" || config.node_manager_address == "localhost"),