[Data] Remove test_hash_shuffle from excluded missing-pytest-main lint
#59247
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
changed the title
test_hash_shuffle from excluded missing-pytest-main lint
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes python/ray/data/tests/test_hash_shuffle.py from the exclusion list for the missing-pytest-main semgrep rule. This is a follow-up to a previous change that added the necessary pytest.main call to the test file, ensuring it runs correctly in CI. The change is correct and aligns with the description. I have no further feedback.
owenowenisme
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI uses Bazel to run Python tests (not pytest). If we don't call
pytest.mainin a test module, the tests aren't actually run.#58816 fixed this issue for
test_hash_shuffle. As a follow up, this PR removes thetest_hash_shufflefrom the list of files excluded from thepytest.mainlint.