Change PhysicalOperator.completed() to has_completed() and update all… #59234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it's references Signed-off-by: Simeet Nayan <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to rename the PhysicalOperator.completed() method to has_completed() for clarity, along with updating all its call sites. The changes are extensive and cover many files, which is great. I've reviewed the changes and they are mostly correct. However, I found one instance in a subclass where the method was overridden but not renamed, which could lead to incorrect behavior. Please see my specific comment for details.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ray-gardener
bot
added
data
Signed-off-by: Simeet Nayan <[email protected]>
Signed-off-by: Simeet Nayan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR after: #58915 for changing the function name from
completed()tohas_completed()in the class PhycicalOperator. This is in-line with our discussions with @bveeramani here: #58915 (review). This is done to make it clear that the method doesn't modify state and has no side effects.Related issues
#58884
Additional information
Just updated the completed() and all it's references in other classes and tests.