[depset] remove headers on all depsets #58917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves logical merge conflicts and fix ci test Signed-off-by: Lonnie Liu <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the auto-generation headers from two uv lock files. These headers contain the exact commands used to generate the files, which is very useful for maintainability. By removing them, it becomes harder for other developers to update these dependencies. While I understand this might be to resolve merge conflicts or CI issues, I've left comments suggesting that it would be better to keep this information. Restoring the headers would be the preferred solution.
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
resolves logical merge conflicts and fix ci test Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: YK <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
resolves logical merge conflicts and fix ci test Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves logical merge conflicts and fix ci test