[data] Add version support to read_lance
#58895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Implementation Signed-off-by: Simeet Nayan <[email protected]>
Signed-off-by: Simeet Nayan <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully adds support for reading specific versions of a Lance dataset by exposing a version parameter in ray.data.read_lance. The change is correctly propagated through the LanceDatasource to the underlying lance.dataset call. The implementation is clean, and the new parameter is well-documented. A comprehensive unit test has been added to verify the new functionality, ensuring that both the latest version (by default) and a specific historical version can be read correctly. I have one minor suggestion to improve a comment in the new test for clarity. Overall, this is a great addition.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Simeet Nayan <[email protected]>
richardliaw
approved these changes
Nov 21, 2025
richardliaw
added
data
Contributor
|
@simeetnayan81 awesome, thanks! |
richardliaw
changed the title
richardliaw
changed the title
read_lance
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
## Description - Expose a version parameter on ray.data.read_lance to read historical Lance dataset versions. - Add unit test python/ray/data/tests/test_lance.py::test_lance_read_with_version that writes an initial dataset, records the initial version, merges new data, and asserts default read returns the latest while read_lance(path, version=initial_version) returns the original columns and rows. ## Related issues > Closes ray-project#58226 ## Additional information As mentioned in the original issue, exposed version parameter in ```read_lance``` function. The parameter is passed down to ```LanceDatasource``` which is updated as well. Ultimately, ```lance.dataset``` takes this version param to read the specific version. --------- Signed-off-by: Simeet Nayan <[email protected]> Signed-off-by: Simeet Nayan <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: YK <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
## Description - Expose a version parameter on ray.data.read_lance to read historical Lance dataset versions. - Add unit test python/ray/data/tests/test_lance.py::test_lance_read_with_version that writes an initial dataset, records the initial version, merges new data, and asserts default read returns the latest while read_lance(path, version=initial_version) returns the original columns and rows. ## Related issues > Closes ray-project#58226 ## Additional information As mentioned in the original issue, exposed version parameter in ```read_lance``` function. The parameter is passed down to ```LanceDatasource``` which is updated as well. Ultimately, ```lance.dataset``` takes this version param to read the specific version. --------- Signed-off-by: Simeet Nayan <[email protected]> Signed-off-by: Simeet Nayan <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Additional information
As mentioned in the original issue, exposed version parameter in
read_lancefunction. The parameter is passed down toLanceDatasourcewhich is updated as well. Ultimately,lance.datasettakes this version param to read the specific version.