Skip to content

Conversation

@zcin
Copy link
Contributor

@zcin zcin commented Nov 21, 2025

Description

Removed unused script, which also has leaked tokens.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

Signed-off-by: Cindy Zhang <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the release/serve_tests/release_utils.py script. This is a crucial change as the script was not only unused but also contained a hardcoded Buildkite API token, which posed a significant security risk. Removing this file effectively mitigates the vulnerability. The change is approved.

@ray-gardener ray-gardener bot added the serve Ray Serve Related Issue label Nov 21, 2025
@zcin zcin added the go add ONLY when ready to merge, run all tests label Nov 21, 2025
@zcin zcin merged commit d972b7d into ray-project:master Nov 21, 2025
6 checks passed
@zcin zcin deleted the remove-outdated-script branch November 21, 2025 18:12
400Ping pushed a commit to 400Ping/ray that referenced this pull request Nov 21, 2025
## Description
Removed unused script, which also has leaked tokens.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: Cindy Zhang <[email protected]>
ykdojo pushed a commit to ykdojo/ray that referenced this pull request Nov 27, 2025
## Description
Removed unused script, which also has leaked tokens.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: YK <[email protected]>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
## Description
Removed unused script, which also has leaked tokens.

## Related issues
> Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to
ray-project#1234".

## Additional information
> Optional: Add implementation details, API changes, usage examples,
screenshots, etc.

Signed-off-by: Cindy Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ray fails to serialize self-reference objects

2 participants