Skip to content

Conversation

@elliot-barn
Copy link
Contributor

@elliot-barn elliot-barn commented Nov 20, 2025

updating llm batch release test depset

successful release test run: https://buildkite.com/ray-project/release/builds/68802#019aa374-b0c3-4da1-a003-9296ac07f4e0

Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
@elliot-barn elliot-barn requested a review from aslonnie November 20, 2025 23:54
@elliot-barn elliot-barn marked this pull request as ready for review November 20, 2025 23:54
@elliot-barn elliot-barn requested a review from a team as a code owner November 20, 2025 23:54
set -exo pipefail

uv pip install --system datasets==4.4.1
uv pip install --system --no-deps --index-strategy unsafe-best-match -r python_depset.lock
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Mismatched lock file path and depset output location

The bash script references python_depset.lock via -r python_depset.lock, but the depset configuration in llm_release_tests.depsets.yaml generates the lock file at release/ray_release/byod/llm_batch/llm_batch_single_node_benchmark_py311_cu128.lock. The script will fail because python_depset.lock does not exist at the expected location. The correct lock file path should be llm_batch/llm_batch_single_node_benchmark_py311_cu128.lock or the depset output path should be adjusted to match where the script expects the lock file.

Fix in Cursor Fix in Web

@ray-gardener ray-gardener bot added serve Ray Serve Related Issue core Issues that should be addressed in Ray Core devprod release-test release test llm labels Nov 21, 2025
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 21, 2025
@elliot-barn elliot-barn requested a review from aslonnie November 21, 2025 23:22
@aslonnie aslonnie merged commit f09600c into master Nov 22, 2025
6 checks passed
@aslonnie aslonnie deleted the elliot-barn/depset-for-llm-batch-test branch November 22, 2025 00:55
ykdojo pushed a commit to ykdojo/ray that referenced this pull request Nov 27, 2025
updating llm batch release test depset

successful release test run:
https://buildkite.com/ray-project/release/builds/68802#019aa374-b0c3-4da1-a003-9296ac07f4e0

---------

Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: YK <[email protected]>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core devprod go add ONLY when ready to merge, run all tests llm release-test release test serve Ray Serve Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants