[Core] remove AUTH_MODE=token check in get-auth-token cli
#58848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sampan <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the requirement for AUTH_MODE=token to be set when using the ray get-auth-token CLI command. This is achieved by introducing an ignore_auth_mode flag that is propagated from the CLI down to the C++ token loading logic. The changes are logical, well-implemented, and include corresponding updates to tests. I have one suggestion to refactor some duplicated code in the Python wrapper for the token loader to improve maintainability.
Signed-off-by: sampan <[email protected]>
edoakes
approved these changes
Nov 24, 2025
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
…ect#58848) ## Description before running `ray get-auth-token` users first need to set `AUTH_MODE=token`. this is unnecessary, this pr introduces `ignore_auth_mode` flag in the token_loader class to remove this check. This pr also moves all auth related tests in `src/ray/rpc/tests` to `src/ray/rpc/authentication/tests`. --------- Signed-off-by: sampan <[email protected]> Co-authored-by: sampan <[email protected]> Signed-off-by: YK <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
…ect#58848) ## Description before running `ray get-auth-token` users first need to set `AUTH_MODE=token`. this is unnecessary, this pr introduces `ignore_auth_mode` flag in the token_loader class to remove this check. This pr also moves all auth related tests in `src/ray/rpc/tests` to `src/ray/rpc/authentication/tests`. --------- Signed-off-by: sampan <[email protected]> Co-authored-by: sampan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
before running
ray get-auth-tokenusers first need to setAUTH_MODE=token. this is unnecessary, this pr introducesignore_auth_modeflag in the token_loader class to remove this check. This pr also moves all auth related tests insrc/ray/rpc/teststosrc/ray/rpc/authentication/tests.