-
Notifications
You must be signed in to change notification settings - Fork 7k
[ci] change CI test bot to use anyscale/ray #58844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rather than ray-project/ray Signed-off-by: Lonnie Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the CI test bot to use the anyscale/ray repository instead of ray-project/ray for tracking test issues. This involves changing the RAY_REPO constant and updating the associated GitHub token secret AWS_SECRET_GITHUB. Additionally, the llm team is added to the list of teams, and constants in state_machine.py are reorganized for better readability. The changes look good overall. I've added one minor suggestion to improve maintainability by sorting the TEAM list.
| TEAM = [ | ||
| "core", | ||
| "data", | ||
| "kuberay", | ||
| "ml", | ||
| "rllib", | ||
| "llm", | ||
| "serve", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability and readability, it's a good practice to keep lists of items like this sorted alphabetically. This makes it easier to find items and to add new ones in the correct place.
| TEAM = [ | |
| "core", | |
| "data", | |
| "kuberay", | |
| "ml", | |
| "rllib", | |
| "llm", | |
| "serve", | |
| ] | |
| TEAM = [ | |
| "core", | |
| "data", | |
| "kuberay", | |
| "llm", | |
| "ml", | |
| "rllib", | |
| "serve", | |
| ] |
rather than ray-project/ray Signed-off-by: Lonnie Liu <[email protected]>
rather than ray-project/ray Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: YK <[email protected]>
rather than ray-project/ray Signed-off-by: Lonnie Liu <[email protected]>
rather than ray-project/ray