[whl] keep building python 3.9 wheels for internal testing #58733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs to keep this until all release tests are migrated. Signed-off-by: Lonnie Liu <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the building of Python 3.9 wheels for internal testing purposes. The change is straightforward, adding '3.9' back to the build matrix in the Buildkite CI configuration. My feedback focuses on improving the maintainability of this change by adding a comment to document its temporary nature, ensuring it can be easily identified and removed in the future.
| commands: | ||
| - bazel run //ci/ray_ci:build_in_docker -- wheel --python-version {{matrix}} --architecture x86_64 --upload | ||
| matrix: | ||
| - "3.9" |
Contributor
There was a problem hiding this comment.
For better maintainability, please add a comment explaining why Python 3.9 is being added back and when it should be removed. This will help future developers understand the context of this temporary change and prevent it from becoming technical debt.
# TODO: Remove this once all release tests are migrated from python 3.9.
- "3.9"
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…ct#58733) needs to keep this until all release tests are migrated. Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
…ct#58733) needs to keep this until all release tests are migrated. Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: YK <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
…ct#58733) needs to keep this until all release tests are migrated. Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs to keep this until all release tests are migrated.