Avoid lock if serialization result is already cached #58722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GIL makes checking s`elf._serialize_cache is not None` atomic, so we don't need lock. Signed-off-by: Xinyuan <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a valid performance optimization to __arrow_ext_serialize__ by adding a check for a cached result before acquiring a lock. This is a standard double-checked locking pattern, which is safe in this context due to Python's GIL ensuring atomic reads for the cache check. The change effectively reduces lock contention when the cache is populated. The implementation is correct and I have no concerns.
raulchen
approved these changes
Nov 18, 2025
raulchen
added
data
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
The GIL makes checking `self._serialize_cache is not None` atomic, so we don't need lock. Signed-off-by: Xinyuan <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Nov 21, 2025
The GIL makes checking `self._serialize_cache is not None` atomic, so we don't need lock. Signed-off-by: Xinyuan <[email protected]>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
The GIL makes checking `self._serialize_cache is not None` atomic, so we don't need lock. Signed-off-by: Xinyuan <[email protected]> Signed-off-by: YK <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
The GIL makes checking `self._serialize_cache is not None` atomic, so we don't need lock. Signed-off-by: Xinyuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GIL makes checking
self._serialize_cache is not Noneatomic, so we don't need lock.