Update Ray Data histograms to show percentiles in data dashboard #58650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Guo <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a great initiative to improve the data dashboard by replacing histograms with P90 percentile graphs for key metrics, which should provide more actionable insights. The old histogram views are thoughtfully preserved within a collapsed "Operator Panels" row for detailed, per-operator analysis.
My review has identified a critical issue in the new PromQL queries for percentile calculations that would render the graphs incorrect. I've provided specific code suggestions to fix this. Additionally, I've included a couple of medium-severity comments to enhance code maintainability by addressing code duplication and removing unused code.
python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
Outdated
Show resolved
Hide resolved
python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
Outdated
Show resolved
Hide resolved
python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
Outdated
Show resolved
Hide resolved
python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
Outdated
Show resolved
Hide resolved
python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
Show resolved
Hide resolved
python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py
Show resolved
Hide resolved
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
ray-gardener
bot
added
docs
bveeramani
approved these changes
Nov 17, 2025
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
python/ray/dashboard/modules/metrics/grafana_dashboard_factory.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Alan Guo <[email protected]>
MengjinYan
approved these changes
Nov 18, 2025
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…-project#58650) ## Description The data grafana dashboard by default should work well when viewing across all operators. Use a percentile graph that is grouped by operator instead. For the histogram bar charts, hide that in the operator panels row. This is useful for areas where we by default filter by a single operator (like in the data dashboard) <img width="1163" height="379" alt="Screenshot 2025-11-14 at 2 33 16 PM" src="https://github.com/user-attachments/assets/fd4a3d0c-4a60-4bb9-a803-859b3ed14a59" /> <img width="1158" height="430" alt="Screenshot 2025-11-14 at 2 33 08 PM" src="https://github.com/user-attachments/assets/a78b4dde-8066-478b-86b4-b838761431f2" /> --------- Signed-off-by: Alan Guo <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
…-project#58650) ## Description The data grafana dashboard by default should work well when viewing across all operators. Use a percentile graph that is grouped by operator instead. For the histogram bar charts, hide that in the operator panels row. This is useful for areas where we by default filter by a single operator (like in the data dashboard) <img width="1163" height="379" alt="Screenshot 2025-11-14 at 2 33 16 PM" src="https://github.com/user-attachments/assets/fd4a3d0c-4a60-4bb9-a803-859b3ed14a59" /> <img width="1158" height="430" alt="Screenshot 2025-11-14 at 2 33 08 PM" src="https://github.com/user-attachments/assets/a78b4dde-8066-478b-86b4-b838761431f2" /> --------- Signed-off-by: Alan Guo <[email protected]> Signed-off-by: YK <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
…-project#58650) ## Description The data grafana dashboard by default should work well when viewing across all operators. Use a percentile graph that is grouped by operator instead. For the histogram bar charts, hide that in the operator panels row. This is useful for areas where we by default filter by a single operator (like in the data dashboard) <img width="1163" height="379" alt="Screenshot 2025-11-14 at 2 33 16 PM" src="https://github.com/user-attachments/assets/fd4a3d0c-4a60-4bb9-a803-859b3ed14a59" /> <img width="1158" height="430" alt="Screenshot 2025-11-14 at 2 33 08 PM" src="https://github.com/user-attachments/assets/a78b4dde-8066-478b-86b4-b838761431f2" /> --------- Signed-off-by: Alan Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The data grafana dashboard by default should work well when viewing across all operators. Use a percentile graph that is grouped by operator instead.
For the histogram bar charts, hide that in the operator panels row. This is useful for areas where we by default filter by a single operator (like in the data dashboard)