Skip to content

[ci] pin docker client version #58579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aslonnie merged 1 commit into from
Nov 13, 2025
Merged

[ci] pin docker client version #58579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ci/docker/forge.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ Signed-by: /etc/apt/keyrings/microsoft.gpg" | sudo tee /etc/apt/sources.list.d/a

apt-get update
apt-get install -y \
awscli docker-ce-cli nodejs build-essential python-is-python3 \
awscli nodejs build-essential python-is-python3 \
python3-pip openjdk-8-jre wget jq \
"docker-ce-cli=5:28.5.2-1~ubuntu.22.04~jammy" \
azure-cli="${AZ_VER}"-1~"${AZ_DIST}"

# Install uv
Expand Down Expand Up @@ -115,4 +116,4 @@ EOF
CMD ["echo", "ray forge"]


# last update: 2025-10-08
# last update: 2025-11-12
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This 'last update' comment appears to be used for triggering CI builds, which can be misleading as it suggests a substantive change to the Dockerfile. To improve clarity and maintain a clean git history, consider using a more explicit method for triggering CI. For example, you could use an empty commit (git commit --allow-empty -m "trigger CI") or change this comment to something more explicit like # CI trigger: <some-number> to make the intent clear.