Skip to content

[java] remove local genrule //java:ray_java_pkg #58503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aslonnie merged 1 commit into from
Nov 10, 2025
Merged

[java] remove local genrule //java:ray_java_pkg #58503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/build/build-manylinux-ray.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ fi

# Build ray java
if [[ "${RAY_INSTALL_JAVA}" == "1" ]]; then
bazel build //java:ray_java_pkg
bazel run //java:gen_ray_java_pkg
fi

export PATH="/usr/local/node/bin:$PATH"
Expand Down
2 changes: 1 addition & 1 deletion ci/docker/ray-java.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if [[ "${BUILDKITE_CACHE_READONLY:-}" == "true" ]]; then
echo "build --remote_upload_local_results=false" >> "$HOME/.bazelrc"
fi

bazelisk build --config=ci //java:ray_java_pkg
bazelisk run --config=ci //java:gen_ray_java_pkg

cp bazel-bin/java/ray_java_pkg.zip /home/forge/ray_java_pkg.zip

Expand Down
20 changes: 0 additions & 20 deletions java/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ java_test(
args = ["java/testng.xml"],
data = [
"testng.xml",
":ray_java_pkg",
"//:ray_pkg_zip",
],
main_class = "org.testng.TestNG",
Expand All @@ -254,7 +253,6 @@ java_test(
args = ["java/testng_custom.xml"],
data = [
"testng_custom.xml",
":ray_java_pkg",
"//:ray_pkg_zip",
],
main_class = "org.testng.TestNG",
Expand Down Expand Up @@ -497,24 +495,6 @@ pkg_zip(
visibility = ["//visibility:private"],
)

genrule(
name = "ray_java_pkg",
srcs = [
"ray_java_pkg.zip",
":gen_maven_deps",
],
outs = ["ray_java_pkg.out"],
cmd = """
WORK_DIR="$$(pwd)" &&
rm -rf "$$WORK_DIR/python/ray/jars" && mkdir -p "$$WORK_DIR/python/ray/jars" &&
unzip -q $(location ray_java_pkg.zip) -d "$$WORK_DIR/python" &&
if [[ "$$OSTYPE" =~ ^darwin ]]; then shasum $(SRCS) > $@ ; else sha1sum $(SRCS) > $@ ; fi
""",
local = 1,
tags = ["no-cache"],
visibility = ["//visibility:private"],
)

py_binary(
name = "gen_ray_java_pkg",
srcs = ["gen_ray_java_pkg.py"],
Expand Down