Skip to content

Conversation

@aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Nov 7, 2025

be consistent with the CI base env specified in --build-name

be consistent with the CI base env specified in `--build-name`

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie requested a review from a team November 7, 2025 19:11
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a typo in a depends_on key within the .buildkite/data.rayci.yml CI configuration file, changing datalbuild-multipy to databuild-multipy. This change is crucial for ensuring the CI pipeline's integrity by referencing the correct build dependency. While reviewing, I noticed a related inconsistency in ci/docker/datal.build.wanda.yaml where name is set to datalbuild-py$PYTHON but the tag is databuild-py$PYTHON. It would be beneficial to correct this in a follow-up to maintain consistency across the CI configuration.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 7, 2025
@aslonnie aslonnie merged commit 412220e into master Nov 7, 2025
6 checks passed
@aslonnie aslonnie deleted the lonnie-251107-datatestfix branch November 7, 2025 22:06
YoussefEssDS pushed a commit to YoussefEssDS/ray that referenced this pull request Nov 8, 2025
be consistent with the CI base env specified in `--build-name`

Signed-off-by: Lonnie Liu <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
be consistent with the CI base env specified in `--build-name`

Signed-off-by: Lonnie Liu <[email protected]>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
be consistent with the CI base env specified in `--build-name`

Signed-off-by: Lonnie Liu <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
ykdojo pushed a commit to ykdojo/ray that referenced this pull request Nov 27, 2025
be consistent with the CI base env specified in `--build-name`

Signed-off-by: Lonnie Liu <[email protected]>
Signed-off-by: YK <[email protected]>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
be consistent with the CI base env specified in `--build-name`

Signed-off-by: Lonnie Liu <[email protected]>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
be consistent with the CI base env specified in `--build-name`

Signed-off-by: Lonnie Liu <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants