-
Notifications
You must be signed in to change notification settings - Fork 7k
[Docs][KubeRay] Mention RayJob gang scheduling for Yunikorn #58375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: win5923 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Yunikorn documentation to mention that KubeRay now supports gang scheduling for RayJob custom resources, which is a helpful clarification. The change is accurate and improves the documentation. I have one minor suggestion to rephrase the added text for better readability.
| ## Step 4: Use Apache YuniKorn for gang scheduling | ||
|
|
||
| This example uses gang scheduling with Apache YuniKorn and KubeRay. | ||
| This example demonstrates gang scheduling of RayCluster custom resources with Apache YuniKorn and KubeRay. Starting with KubeRay 1.5.0, KubeRay also supports gang scheduling for RayJob custom resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this clarification! To improve readability, you could rephrase the second sentence to be more direct and avoid repeating 'KubeRay'.
| This example demonstrates gang scheduling of RayCluster custom resources with Apache YuniKorn and KubeRay. Starting with KubeRay 1.5.0, KubeRay also supports gang scheduling for RayJob custom resources. | |
| This example demonstrates gang scheduling of RayCluster custom resources with Apache YuniKorn and KubeRay. Gang scheduling for RayJob custom resources is also supported, starting with KubeRay v1.5.0. |
…ect#58375) Starting with KubeRay 1.5.0, KubeRay supports gang scheduling for RayJob custom resources. Just add a mention for Yunikorn scheduler. Related to ray-project/kuberay#3948. Signed-off-by: win5923 <[email protected]>
…ect#58375) Starting with KubeRay 1.5.0, KubeRay supports gang scheduling for RayJob custom resources. Just add a mention for Yunikorn scheduler. Related to ray-project/kuberay#3948. Signed-off-by: win5923 <[email protected]>
…ect#58375) Starting with KubeRay 1.5.0, KubeRay supports gang scheduling for RayJob custom resources. Just add a mention for Yunikorn scheduler. Related to ray-project/kuberay#3948. Signed-off-by: win5923 <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
…ect#58375) Starting with KubeRay 1.5.0, KubeRay supports gang scheduling for RayJob custom resources. Just add a mention for Yunikorn scheduler. Related to ray-project/kuberay#3948. Signed-off-by: win5923 <[email protected]>
Description
Starting with KubeRay 1.5.0, KubeRay supports gang scheduling for RayJob custom resources.
Just add a mention for Yunikorn scheduler.
Related issues
Related to ray-project/kuberay#3948.
Additional information
None.