Skip to content

Conversation

@aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Nov 3, 2025

python 3.9 is out of support window

python 3.9 is out of support window

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie requested review from elliot-barn and khluu November 3, 2025 14:14
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes Python 3.9 from the build matrices in .buildkite/build.rayci.yml, aligning with the decision to stop supporting it.

However, the effort to remove Python 3.9 from the codebase appears to be incomplete. To ensure consistency and prevent builds from using an unsupported Python version, I recommend extending the changes to other files where Python 3.9 is still referenced:

  • build-docker.sh: This script for building docker images locally defaults to Python 3.9.
    • Line 10: PYTHON_VERSION="3.9" should be updated to a supported version (e.g., "3.10").
    • Lines 8-9: The WHEEL_URL and CPP_WHEEL_URL point to cp39 wheels. These should also be updated.
  • ci/build/copy_build_artifacts.sh: This script hardcodes the Python 3.9 path.
    • Line 36: export PATH=/opt/python/cp39-cp39/bin:$PATH should be updated or made dynamic to use a supported Python version.

Addressing these will make the removal of Python 3.9 more robust across the project.

- raycudabase
- raycpubase
matrix:
- "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While removing Python 3.9 from this build matrix is the right step, the overall goal of this PR to stop building Python 3.9 images seems incomplete. Other scripts in the repository still use Python 3.9 for building images (e.g., build-docker.sh). To fully deprecate Python 3.9, all related scripts should be updated. Please see the general summary comment for a detailed list of files.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 3, 2025
@aslonnie aslonnie merged commit d3d6b6b into master Nov 3, 2025
6 checks passed
@aslonnie aslonnie deleted the lonnie-251103-nopy39img branch November 3, 2025 17:43
YoussefEssDS pushed a commit to YoussefEssDS/ray that referenced this pull request Nov 8, 2025
python 3.9 is out of support window

Signed-off-by: Lonnie Liu <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
python 3.9 is out of support window

Signed-off-by: Lonnie Liu <[email protected]>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
python 3.9 is out of support window

Signed-off-by: Lonnie Liu <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
python 3.9 is out of support window

Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants