[wheel] stop uploading python 3.9 wheels on release #58363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes Python 3.9 from the wheel build process by updating PYTHON_VERSIONS. The corresponding test file is also updated to reflect this change. I've added several suggestions to the test file to reduce code duplication by consistently using the _SAMPLE_WHEELS constant. Applying these suggestions will improve the maintainability of the tests.
Comment on lines
57
to
62
| wheels = [ | ||
| "ray-1.0.0-cp39-cp39-manylinux2014_x86_64", | ||
| "ray-1.0.0-cp39-cp39-manylinux2014_aarch64", | ||
| "ray-1.0.0-cp39-cp39-macosx_12_0_arm64", | ||
| "ray-1.0.0-cp39-cp39-win_amd64", | ||
| "ray-1.0.0-cp312-cp312-manylinux2014_x86_64", | ||
| "ray-1.0.0-cp312-cp312-manylinux2014_aarch64", | ||
| "ray-1.0.0-cp312-cp312-macosx_12_0_arm64", | ||
| "ray-1.0.0-cp312-cp312-win_amd64", | ||
| ] |
Contributor
There was a problem hiding this comment.
To improve maintainability and reduce code duplication, you can use the _SAMPLE_WHEELS constant here instead of redefining the list.
wheels = _SAMPLE_WHEELS
Comment on lines
73
to
78
| wheels = [ | ||
| "ray-1.0.0-cp39-cp39-manylinux2014_x86_64", | ||
| "ray-1.0.0-cp39-cp39-manylinux2014_aarch64", | ||
| "ray-1.0.0-cp39-cp39-macosx_12_0_arm64", | ||
| "ray-1.0.0-cp39-cp39-win_amd64", | ||
| "ray-1.0.0-cp312-cp312-manylinux2014_x86_64", | ||
| "ray-1.0.0-cp312-cp312-manylinux2014_aarch64", | ||
| "ray-1.0.0-cp312-cp312-macosx_12_0_arm64", | ||
| "ray-1.0.0-cp312-cp312-win_amd64", | ||
| ] |
Contributor
There was a problem hiding this comment.
Similar to the previous test, you can use _SAMPLE_WHEELS here to avoid duplicating the list of wheels.
wheels = _SAMPLE_WHEELS
Comment on lines
91
to
96
| keys = [ | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp39-cp39-manylinux2014_x86_64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp39-cp39-manylinux2014_aarch64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp39-cp39-macosx_12_0_arm64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp39-cp39-win_amd64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp312-cp312-manylinux2014_x86_64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp312-cp312-manylinux2014_aarch64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp312-cp312-macosx_12_0_arm64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp312-cp312-win_amd64.whl", | ||
| ] |
Contributor
There was a problem hiding this comment.
This list of keys can be generated dynamically from _SAMPLE_WHEELS to make the test more maintainable and less prone to errors if the sample wheels change.
keys = [f"releases/1.0.0/1234567/{wheel}.whl" for wheel in _SAMPLE_WHEELS]
Comment on lines
117
to
120
| keys = [ | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp39-cp39-manylinux2014_x86_64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp39-cp39-manylinux2014_aarch64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp312-cp312-manylinux2014_x86_64.whl", | ||
| "releases/1.0.0/1234567/ray-1.0.0-cp312-cp312-manylinux2014_aarch64.whl", | ||
| ] |
Contributor
There was a problem hiding this comment.
This list of keys can also be generated from _SAMPLE_WHEELS to keep the test data consistent.
keys = [f"releases/1.0.0/1234567/{wheel}.whl" for wheel in _SAMPLE_WHEELS[:2]]
Comment on lines
278
to
282
| wheels = [ | ||
| "ray-1.0.0-cp39-cp39-manylinux2014_x86_64.whl", | ||
| "ray-1.0.0-cp39-cp39-manylinux2014_aarch64.whl", | ||
| "ray-1.0.0-cp312-cp312-manylinux2014_x86_64.whl", | ||
| "ray-1.0.0-cp312-cp312-manylinux2014_aarch64.whl", | ||
| ] |
Contributor
There was a problem hiding this comment.
This list of wheels can be derived from _SAMPLE_WHEELS to avoid hardcoding and improve consistency.
wheels = [f"{wheel}.whl" for wheel in _SAMPLE_WHEELS[:2]]
Comment on lines
286
to
292
| assert os.path.exists( | ||
| os.path.join(tmp_dir, "ray-1.0.0-123-cp39-cp39-manylinux2014_x86_64.whl") | ||
| os.path.join(tmp_dir, "ray-1.0.0-123-cp312-cp312-manylinux2014_x86_64.whl") | ||
| ) | ||
| assert os.path.exists( | ||
| os.path.join(tmp_dir, "ray-1.0.0-123-cp39-cp39-manylinux2014_aarch64.whl") | ||
| os.path.join(tmp_dir, "ray-1.0.0-123-cp312-cp312-manylinux2014_aarch64.whl") | ||
| ) |
Contributor
There was a problem hiding this comment.
These assertions can be made more robust and maintainable by generating the expected wheel names from _SAMPLE_WHEELS and using a loop.
for wheel_base in _SAMPLE_WHEELS[:2]:
parts = wheel_base.split("-")
parts.insert(2, "123")
expected_wheel = "-".join(parts) + ".whl"
assert os.path.exists(os.path.join(tmp_dir, expected_wheel))
khluu
approved these changes
Nov 3, 2025
python 3.9 is now out of the support window Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
force-pushed
the
lonnie-251102-drop39rel
branch
from
016739b to
dd5f321
Compare
harshit-anyscale
pushed a commit
that referenced
this pull request
Nov 7, 2025
author Lonnie Liu <[email protected]> 1762143156 -0800 committer harshit <[email protected]> 1762519796 +0000 parent c4f0c24 author Lonnie Liu <[email protected]> 1762143156 -0800 committer harshit <[email protected]> 1762519679 +0000 [wheel] stop uploading python 3.9 wheels on release (#58363) python 3.9 is now out of the support window all using python 3.12 wheel names for unit testing Signed-off-by: Lonnie Liu <[email protected]> [ci] stop verifying python 3.9 wheels (#58365) we will stop releasing them Signed-off-by: Lonnie Liu <[email protected]> [bazel] rename python runtime to py39 runtime (#58362) and move them into bazel dir. getting ready for python version upgrade Signed-off-by: Lonnie Liu <[email protected]> add template for async inf Signed-off-by: harshit <[email protected]> minor changes Signed-off-by: harshit <[email protected]> template for async inf Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]> fix tests Signed-off-by: harshit <[email protected]>
YoussefEssDS
pushed a commit
to YoussefEssDS/ray
that referenced
this pull request
Nov 8, 2025
python 3.9 is now out of the support window all using python 3.12 wheel names for unit testing Signed-off-by: Lonnie Liu <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
python 3.9 is now out of the support window all using python 3.12 wheel names for unit testing Signed-off-by: Lonnie Liu <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
python 3.9 is now out of the support window all using python 3.12 wheel names for unit testing Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
python 3.9 is now out of the support window all using python 3.12 wheel names for unit testing Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python 3.9 is now out of the support window
all using python 3.12 wheel names for unit testing