Skip to content

Conversation

@morotti
Copy link
Contributor

@morotti morotti commented Oct 31, 2025

Hello,

I'd like to upstream this fix that was done internally at my company.

When running on older machines with less impressive CPU, and when under a bit of load. We've seen the dashboard failing to start in the expected 200 iterations (sleep(0.1) for 20 seconds).
We had to patch ray to allow 60 seconds for startup.

Regards.

@morotti morotti requested a review from a team as a code owner October 31, 2025 13:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the startup timeout for the Ray dashboard from 20 to 60 seconds. This is a sensible adjustment to accommodate slower machines or systems under heavy load, preventing premature startup failures. My feedback focuses on improving code readability by making the timeout value more explicit.

@edoakes
Copy link
Collaborator

edoakes commented Oct 31, 2025

@morotti thanks for the contribution, this looks reasonable to me. While you're at it, do you mind making this controllable via an environment variable? You can add it here:

I'd call it RAY_DASHBOARD_STARTUP_TIMEOUT_S with a default value of 60.

@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Oct 31, 2025
@morotti
Copy link
Contributor Author

morotti commented Oct 31, 2025

While you're at it, do you mind making this controllable via an environment variable? You can add it here:

@edoakes May I ask for you to do the patch if you want something more specific? I'm really not familiar with your codebase to look into how to read environment variable and give you tests and etc.. I'm sure you can do it in 10 minutes.

I really don't mind about not getting credit for the commit/PR. I just need the library fixed. :)

@edoakes edoakes changed the title [critical][bugfix][trivial] dashboard: allow 60 seconds for the dashboard to start dashboard: allow 60 seconds for the dashboard to start Oct 31, 2025
@edoakes
Copy link
Collaborator

edoakes commented Oct 31, 2025

While you're at it, do you mind making this controllable via an environment variable? You can add it here:

@edoakes May I ask for you to do the patch if you want something more specific? I'm really not familiar with your codebase to look into how to read environment variable and give you tests and etc.. I'm sure you can do it in 10 minutes.

I really don't mind about not getting credit for the commit/PR. I just need the library fixed. :)

yes, done

@edoakes edoakes enabled auto-merge (squash) October 31, 2025 18:25
@ray-gardener ray-gardener bot added core Issues that should be addressed in Ray Core community-contribution Contributed by the community labels Oct 31, 2025
@edoakes edoakes merged commit 239802d into ray-project:master Oct 31, 2025
6 of 7 checks passed
YoussefEssDS pushed a commit to YoussefEssDS/ray that referenced this pull request Nov 8, 2025
…8341)

When running on older machines with less impressive CPU, and when under
a bit of load. We've seen the dashboard failing to start in the expected
200 iterations (`sleep(0.1)` for 20 seconds). Increases this timeout to 60 seconds.

---------

Signed-off-by: morotti <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
…8341)

When running on older machines with less impressive CPU, and when under
a bit of load. We've seen the dashboard failing to start in the expected
200 iterations (`sleep(0.1)` for 20 seconds). Increases this timeout to 60 seconds.

---------

Signed-off-by: morotti <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
…8341)

When running on older machines with less impressive CPU, and when under
a bit of load. We've seen the dashboard failing to start in the expected
200 iterations (`sleep(0.1)` for 20 seconds). Increases this timeout to 60 seconds.

---------

Signed-off-by: morotti <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
…8341)

When running on older machines with less impressive CPU, and when under
a bit of load. We've seen the dashboard failing to start in the expected
200 iterations (`sleep(0.1)` for 20 seconds). Increases this timeout to 60 seconds.

---------

Signed-off-by: morotti <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Co-authored-by: Edward Oakes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants