-
Notifications
You must be signed in to change notification settings - Fork 7k
dashboard: allow 60 seconds for the dashboard to start #58341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: morotti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request increases the startup timeout for the Ray dashboard from 20 to 60 seconds. This is a sensible adjustment to accommodate slower machines or systems under heavy load, preventing premature startup failures. My feedback focuses on improving code readability by making the timeout value more explicit.
|
@morotti thanks for the contribution, this looks reasonable to me. While you're at it, do you mind making this controllable via an environment variable? You can add it here:
I'd call it |
@edoakes May I ask for you to do the patch if you want something more specific? I'm really not familiar with your codebase to look into how to read environment variable and give you tests and etc.. I'm sure you can do it in 10 minutes. I really don't mind about not getting credit for the commit/PR. I just need the library fixed. :) |
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
yes, done |
…8341) When running on older machines with less impressive CPU, and when under a bit of load. We've seen the dashboard failing to start in the expected 200 iterations (`sleep(0.1)` for 20 seconds). Increases this timeout to 60 seconds. --------- Signed-off-by: morotti <[email protected]> Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Edward Oakes <[email protected]>
…8341) When running on older machines with less impressive CPU, and when under a bit of load. We've seen the dashboard failing to start in the expected 200 iterations (`sleep(0.1)` for 20 seconds). Increases this timeout to 60 seconds. --------- Signed-off-by: morotti <[email protected]> Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Edward Oakes <[email protected]>
…8341) When running on older machines with less impressive CPU, and when under a bit of load. We've seen the dashboard failing to start in the expected 200 iterations (`sleep(0.1)` for 20 seconds). Increases this timeout to 60 seconds. --------- Signed-off-by: morotti <[email protected]> Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
…8341) When running on older machines with less impressive CPU, and when under a bit of load. We've seen the dashboard failing to start in the expected 200 iterations (`sleep(0.1)` for 20 seconds). Increases this timeout to 60 seconds. --------- Signed-off-by: morotti <[email protected]> Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Edward Oakes <[email protected]>
Hello,
I'd like to upstream this fix that was done internally at my company.
When running on older machines with less impressive CPU, and when under a bit of load. We've seen the dashboard failing to start in the expected 200 iterations (
sleep(0.1)for 20 seconds).We had to patch ray to allow 60 seconds for startup.
Regards.