Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/ray/util/spark/cluster_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -843,11 +843,12 @@ def _setup_ray_cluster_internal(
if not (
spark_master.startswith("spark://")
or spark_master.startswith("local-cluster[")
or spark_master == "yarn"
or is_spark_local_mode
):
raise RuntimeError(
"Ray on Spark only supports spark cluster in standalone mode, "
"local-cluster mode or spark local mode."
"local-cluster mode, spark on yarn mode or spark local mode."
)
Comment on lines 849 to 852
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve debuggability, consider including the detected spark_master value in the error message. This will help users quickly identify misconfigurations when they are using an unsupported Spark master.

Suggested change
raise RuntimeError(
"Ray on Spark only supports spark cluster in standalone mode, "
"local-cluster mode or spark local mode."
"local-cluster mode, spark on yarn mode or spark local mode."
)
raise RuntimeError(
"Ray on Spark only supports spark cluster in standalone mode, "
"local-cluster mode, spark on yarn mode or spark local mode. "
f"Detected spark master is '{spark_master}'."
)


if is_spark_local_mode:
Expand Down