[Data] - TPCH Q1 Release Test - Expr #58331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutam <[email protected]>
Signed-off-by: Goutam <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a great improvement, replacing map_batches with with_column and Arrow expressions for the TPC-H Q1 benchmark. This change enhances both performance and readability, making the implementation much cleaner. I've identified a couple of opportunities to further improve the code by reusing newly created float columns, which will help avoid redundant computations and increase clarity.
Signed-off-by: Goutam <[email protected]>
goutamvenkat-anyscale
added
data
Signed-off-by: Goutam <[email protected]>
|
|
||
| # Build float views + derived columns | ||
| ds = ( | ||
| ds.with_column("l_quantity_f", to_f64(col("column04"))) |
Contributor
There was a problem hiding this comment.
You'll need to rename the columns first as our dataset has bogus column names
alexeykudinkin
approved these changes
Oct 31, 2025
Signed-off-by: Goutam <[email protected]>
alexeykudinkin
approved these changes
Oct 31, 2025
Comment on lines
+39
to
+57
| .rename_columns( | ||
| { | ||
| "column00": "l_orderkey", | ||
| "column02": "l_suppkey", | ||
| "column03": "l_linenumber", | ||
| "column04": "l_quantity", | ||
| "column05": "l_extendedprice", | ||
| "column06": "l_discount", | ||
| "column07": "l_tax", | ||
| "column08": "l_returnflag", | ||
| "column09": "l_linestatus", | ||
| "column10": "l_shipdate", | ||
| "column11": "l_commitdate", | ||
| "column12": "l_receiptdate", | ||
| "column13": "l_shipinstruct", | ||
| "column14": "l_shipmode", | ||
| "column15": "l_comment", | ||
| } | ||
| ) |
Contributor
There was a problem hiding this comment.
This is gonna be broken https://anyscale1.atlassian.net/browse/DATA-1610
Contributor
|
@goutamvenkat-anyscale how were u able to get around the empty partition? |
YoussefEssDS
pushed a commit
to YoussefEssDS/ray
that referenced
this pull request
Nov 8, 2025
## Description Replace `map_batches` and numpy invocations with `with_column` and arrow kernels Release test: https://buildkite.com/ray-project/release/builds/66243#019a37da-4d9d-4f19-9180-e3f3dc3f8043 ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
## Description Replace `map_batches` and numpy invocations with `with_column` and arrow kernels Release test: https://buildkite.com/ray-project/release/builds/66243#019a37da-4d9d-4f19-9180-e3f3dc3f8043 ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
## Description Replace `map_batches` and numpy invocations with `with_column` and arrow kernels Release test: https://buildkite.com/ray-project/release/builds/66243#019a37da-4d9d-4f19-9180-e3f3dc3f8043 ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
## Description Replace `map_batches` and numpy invocations with `with_column` and arrow kernels Release test: https://buildkite.com/ray-project/release/builds/66243#019a37da-4d9d-4f19-9180-e3f3dc3f8043 ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <[email protected]>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
## Description Replace `map_batches` and numpy invocations with `with_column` and arrow kernels Release test: https://buildkite.com/ray-project/release/builds/66243#019a37da-4d9d-4f19-9180-e3f3dc3f8043 ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. --------- Signed-off-by: Goutam <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
map_batchesand numpy invocations withwith_columnand arrow kernelsRelease test: https://buildkite.com/ray-project/release/builds/66243#019a37da-4d9d-4f19-9180-e3f3dc3f8043
Related issues
Additional information