Skip to content

Conversation

@elliot-barn
Copy link
Contributor

removing byod compile jobs for release test images
Now using raydepsets to generate lock files

Signed-off-by: elliot-barn <[email protected]>
@elliot-barn elliot-barn requested a review from aslonnie October 30, 2025 17:09
@elliot-barn elliot-barn changed the title removing byod compile jobs [ci][release] removing byod compile jobs Oct 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several compile_pip_requirements bazel targets, which is a good cleanup step as the project has moved to using raydepsets for generating lock files. My main feedback is that the corresponding requirements_*.in and requirements_*.txt files are now obsolete and contain broken update instructions. I've left a specific comment suggesting their removal to ensure the repository remains consistent and maintainable.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Oct 30, 2025
@aslonnie aslonnie merged commit dc5bcd4 into master Oct 30, 2025
7 checks passed
@aslonnie aslonnie deleted the elliot-barn/cleaning-up-old-release-dep-jobs branch October 30, 2025 23:44
YoussefEssDS pushed a commit to YoussefEssDS/ray that referenced this pull request Nov 8, 2025
removing byod compile jobs for release test images
Now using raydepsets to generate lock files

Signed-off-by: elliot-barn <[email protected]>
Co-authored-by: Lonnie Liu <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
removing byod compile jobs for release test images
Now using raydepsets to generate lock files

Signed-off-by: elliot-barn <[email protected]>
Co-authored-by: Lonnie Liu <[email protected]>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
removing byod compile jobs for release test images
Now using raydepsets to generate lock files

Signed-off-by: elliot-barn <[email protected]>
Co-authored-by: Lonnie Liu <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
removing byod compile jobs for release test images
Now using raydepsets to generate lock files

Signed-off-by: elliot-barn <[email protected]>
Co-authored-by: Lonnie Liu <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devprod go add ONLY when ready to merge, run all tests release-test release test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants