[core] add entrypoint log for jobs #58300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfellowes-anyscale
changed the title
edoakes
reviewed
Oct 30, 2025
| # Open in append mode to avoid overwriting runtime_env setup logs for the | ||
| # supervisor actor, which are also written to the same file. | ||
| with open(logs_path, "a") as logs_file: | ||
| self._logger.info(f"Running entrypoint for job {self._job_id}: {self._entrypoint}\n") |
Collaborator
There was a problem hiding this comment.
I haven't touched this code in a long while, but I believe self._logger goes to a log file for this supervisor actor, not the log file for the job itself. You'll want to write this to the logs_file that was opened a line above instead.
Signed-off-by: Chris Fellowes <[email protected]>
Signed-off-by: chrisfellowes <[email protected]> Signed-off-by: Chris Fellowes <[email protected]>
Signed-off-by: Chris Fellowes <[email protected]>
Signed-off-by: Chris Fellowes <[email protected]>
chrisfellowes-anyscale
force-pushed
the
master
branch
from
3724561 to
b7afa9a
Compare
edoakes
approved these changes
Oct 30, 2025
Collaborator
edoakes
left a comment
edoakes
left a comment
There was a problem hiding this comment.
LGTM assuming tests pass. I just added the go label, which will run the full CI tests.
| # Open in append mode to avoid overwriting runtime_env setup logs for the | ||
| # supervisor actor, which are also written to the same file. | ||
| with open(logs_path, "a") as logs_file: | ||
| logs_file.write(f"Running entrypoint for job {self._job_id}: {self._entrypoint}\n") |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| logs_file.write(f"Running entrypoint for job {self._job_id}: {self._entrypoint}\n") | |
| logs_file.write(f"Running entrypoint for job '{self._job_id}': {self._entrypoint}\n") |
Collaborator
|
Linter is failing: https://buildkite.com/ray-project/microcheck/builds/30180#019a35ad-f7f5-4910-941d-7a244b4f1c05/186-305 Instructions for local linting here: https://docs.ray.io/en/latest/ray-contribute/getting-involved.html#lint-and-formatting |
ray-gardener
bot
added
core
Signed-off-by: Chris Fellowes <[email protected]>
edoakes
changed the title
…sfellowes-anyscale/master
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Chris Fellowes <[email protected]>
auto-merge was automatically disabled
October 31, 2025 16:02
Head branch was pushed to by a user without write access
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Chris Fellowes <[email protected]>
Signed-off-by: Chris Fellowes <[email protected]>
YoussefEssDS
pushed a commit
to YoussefEssDS/ray
that referenced
this pull request
Nov 8, 2025
this helps prevent an edge case when using file based log exporters like vector that use fingerprinting [ref](https://vector.dev/docs/reference/configuration/sources/file/#fingerprint) to identify unique files. example edge case that this fixes: two jobs are submitted to a cluster and begin executing at the same time, they both contain an invalid entrypoint that references a nonexistant file before fix: - both jobs have the identical "Runtime env is setting up" log with identical timestamps - both jobs have identical entrypoint failure logs as a result, the log files for these jobs are identical, so vector will only export one. after fix: - both jobs have the identical "Runtime env is setting up" log with identical timestamps - each job has a **unique** entrypoint log containing its job_id - both jobs have identical entrypoint failure logs vector can differentiate between these two files, so both will be exported --------- Signed-off-by: Chris Fellowes <[email protected]> Signed-off-by: chrisfellowes <[email protected]> Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Edward Oakes <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
this helps prevent an edge case when using file based log exporters like vector that use fingerprinting [ref](https://vector.dev/docs/reference/configuration/sources/file/#fingerprint) to identify unique files. example edge case that this fixes: two jobs are submitted to a cluster and begin executing at the same time, they both contain an invalid entrypoint that references a nonexistant file before fix: - both jobs have the identical "Runtime env is setting up" log with identical timestamps - both jobs have identical entrypoint failure logs as a result, the log files for these jobs are identical, so vector will only export one. after fix: - both jobs have the identical "Runtime env is setting up" log with identical timestamps - each job has a **unique** entrypoint log containing its job_id - both jobs have identical entrypoint failure logs vector can differentiate between these two files, so both will be exported --------- Signed-off-by: Chris Fellowes <[email protected]> Signed-off-by: chrisfellowes <[email protected]> Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Edward Oakes <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
this helps prevent an edge case when using file based log exporters like vector that use fingerprinting [ref](https://vector.dev/docs/reference/configuration/sources/file/#fingerprint) to identify unique files. example edge case that this fixes: two jobs are submitted to a cluster and begin executing at the same time, they both contain an invalid entrypoint that references a nonexistant file before fix: - both jobs have the identical "Runtime env is setting up" log with identical timestamps - both jobs have identical entrypoint failure logs as a result, the log files for these jobs are identical, so vector will only export one. after fix: - both jobs have the identical "Runtime env is setting up" log with identical timestamps - each job has a **unique** entrypoint log containing its job_id - both jobs have identical entrypoint failure logs vector can differentiate between these two files, so both will be exported --------- Signed-off-by: Chris Fellowes <[email protected]> Signed-off-by: chrisfellowes <[email protected]> Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Edward Oakes <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
this helps prevent an edge case when using file based log exporters like vector that use fingerprinting [ref](https://vector.dev/docs/reference/configuration/sources/file/#fingerprint) to identify unique files. example edge case that this fixes: two jobs are submitted to a cluster and begin executing at the same time, they both contain an invalid entrypoint that references a nonexistant file before fix: - both jobs have the identical "Runtime env is setting up" log with identical timestamps - both jobs have identical entrypoint failure logs as a result, the log files for these jobs are identical, so vector will only export one. after fix: - both jobs have the identical "Runtime env is setting up" log with identical timestamps - each job has a **unique** entrypoint log containing its job_id - both jobs have identical entrypoint failure logs vector can differentiate between these two files, so both will be exported --------- Signed-off-by: Chris Fellowes <[email protected]> Signed-off-by: chrisfellowes <[email protected]> Signed-off-by: Edward Oakes <[email protected]> Co-authored-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this helps prevent an edge case when using file based log exporters like vector that use fingerprinting ref to identify unique files.
example edge case that this fixes:
two jobs are submitted to a cluster and begin executing at the same time, they both contain an invalid entrypoint that references a nonexistant file
before fix:
as a result, the log files for these jobs are identical, so vector will only export one.
after fix:
vector can differentiate between these two files, so both will be exported
Related issues
Additional information