Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions release/perf_metrics/benchmarks/many_actors.json
Original file line number Diff line number Diff line change
@@ -1,32 +1,31 @@
{
"_dashboard_memory_usage_mb": 108.838912,
"_dashboard_memory_usage_mb": 104.996864,
"_dashboard_test_success": true,
"_peak_memory": 4.57,
"_peak_process_memory": "PID\tMEM\tCOMMAND\n3786\t2.08GiB\t/home/ray/anaconda3/lib/python3.9/site-packages/ray/core/src/ray/gcs/gcs_server --log_dir=/tmp/ray/s\n6618\t0.81GiB\tpython distributed/test_many_actors.py\n3245\t0.36GiB\tvector --watch-config --log-format json --config-yaml /etc/vector/vector.yaml\n4000\t0.25GiB\tray-dashboard-NodeHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import sp\n1389\t0.11GiB\t/app/product/go/infra/anyscaled/anyscaled_/anyscaled startv2 --control_plane_url=https://console.any\n4496\t0.1GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/a\n3216\t0.09GiB\t/usr/bin/python3 /app/infra/dataplane/webterminal/webterminal_sidecar_image.binary.runfiles/product/\n4498\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/ru\n3919\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/dash\n6383\t0.07GiB\tray::JobSupervisor",
"actors_per_second": 508.9808896382363,
"_peak_memory": 4.81,
"_peak_process_memory": "PID\tMEM\tCOMMAND\n1132\t7.8GiB\t/app/product/go/infra/anyscaled/anyscaled_/anyscaled startv2 --control_plane_url=https://console.any\n3490\t2.13GiB\t/home/ray/anaconda3/lib/python3.9/site-packages/ray/core/src/ray/gcs/gcs_server --log_dir=/tmp/ray/s\n5530\t0.95GiB\tpython distributed/test_many_actors.py\n2919\t0.38GiB\tvector --watch-config --log-format json --config-yaml /etc/vector/vector.yaml\n3716\t0.26GiB\tray-dashboard-NodeHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import sp\n585\t0.2GiB\t/app/go/infra/anyscaled/anyscaled_/anyscaled_shim --cloud_provider=aws\n4196\t0.11GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/a\n3066\t0.1GiB\t/usr/bin/python3 /app/infra/dataplane/webterminal/webterminal_sidecar_image.binary.runfiles/product/\n3620\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/dash\n4198\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/ru",
"actors_per_second": 387.1219957094043,
"num_actors": 10000,
"perf_metrics": [
{
"perf_metric_name": "actors_per_second",
"perf_metric_type": "THROUGHPUT",
"perf_metric_value": 508.9808896382363
"perf_metric_value": 387.1219957094043
},
{
"perf_metric_name": "dashboard_p50_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 11.744
"perf_metric_value": 30.836
},
{
"perf_metric_name": "dashboard_p95_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 2876.107
"perf_metric_value": 3829.61
},
{
"perf_metric_name": "dashboard_p99_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 4160.517
"perf_metric_value": 4098.851
}
],
"success": "1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

I see that the success field is being removed from this and several other benchmark result files. This is a good cleanup, as its type (string vs. number) and presence were inconsistent across files. However, release/perf_metrics/scalability/single_node.json still contains this field. To complete the cleanup, it should probably be removed from there as well for consistency.

"time": 19.64710307121277
"time": 25.831650257110596
}
19 changes: 9 additions & 10 deletions release/perf_metrics/benchmarks/many_nodes.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"_dashboard_memory_usage_mb": 98.254848,
"_dashboard_memory_usage_mb": 90.251264,
"_dashboard_test_success": true,
"_peak_memory": 2.33,
"_peak_process_memory": "PID\tMEM\tCOMMAND\n3580\t0.52GiB\t/home/ray/anaconda3/lib/python3.9/site-packages/ray/core/src/ray/gcs/gcs_server --log_dir=/tmp/ray/s\n3098\t0.28GiB\tvector --watch-config --log-format json --config-yaml /etc/vector/vector.yaml\n5630\t0.17GiB\tpython distributed/test_many_tasks.py --num-tasks=1000\n3796\t0.13GiB\tray-dashboard-NodeHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import sp\n1458\t0.11GiB\t/app/product/go/infra/anyscaled/anyscaled_/anyscaled startv2 --control_plane_url=https://console.any\n4276\t0.11GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/a\n3020\t0.09GiB\t/usr/bin/python3 /app/infra/dataplane/webterminal/webterminal_sidecar_image.binary.runfiles/product/\n3713\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/dash\n4278\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/ru\n5857\t0.09GiB\tray::StateAPIGeneratorActor.start",
"_peak_memory": 2.42,
"_peak_process_memory": "PID\tMEM\tCOMMAND\n3297\t0.64GiB\t/home/ray/anaconda3/lib/python3.9/site-packages/ray/core/src/ray/gcs/gcs_server --log_dir=/tmp/ray/s\n2878\t0.29GiB\tvector --watch-config --log-format json --config-yaml /etc/vector/vector.yaml\n5295\t0.17GiB\tpython distributed/test_many_tasks.py --num-tasks=1000\n3510\t0.14GiB\tray-dashboard-NodeHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import sp\n1172\t0.13GiB\t/app/product/go/infra/anyscaled/anyscaled_/anyscaled startv2 --control_plane_url=https://console.any\n3996\t0.11GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/a\n2813\t0.1GiB\t/usr/bin/python3 /app/infra/dataplane/webterminal/webterminal_sidecar_image.binary.runfiles/product/\n3998\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/ru\n3427\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/dash\n5522\t0.08GiB\tray::StateAPIGeneratorActor.start",
"num_tasks": 1000,
"perf_metrics": [
{
"perf_metric_name": "tasks_per_second",
"perf_metric_type": "THROUGHPUT",
"perf_metric_value": 190.09519026949954
"perf_metric_value": 355.96107999624206
},
{
"perf_metric_name": "used_cpus_by_deadline",
Expand All @@ -18,21 +18,20 @@
{
"perf_metric_name": "dashboard_p50_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 7.136
"perf_metric_value": 6.475
},
{
"perf_metric_name": "dashboard_p95_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 13.982
"perf_metric_value": 17.834
},
{
"perf_metric_name": "dashboard_p99_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 49.716
"perf_metric_value": 67.355
}
],
"success": "1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The success field is being removed here, which improves consistency across benchmark files. It's worth noting that release/perf_metrics/scalability/single_node.json still includes this field. For complete consistency, it should be removed there too.

"tasks_per_second": 190.09519026949954,
"time": 305.26052236557007,
"tasks_per_second": 355.96107999624206,
"time": 302.80929589271545,
"used_cpus": 250.0
}
19 changes: 9 additions & 10 deletions release/perf_metrics/benchmarks/many_pgs.json
Original file line number Diff line number Diff line change
@@ -1,32 +1,31 @@
{
"_dashboard_memory_usage_mb": 90.76736,
"_dashboard_memory_usage_mb": 99.979264,
"_dashboard_test_success": true,
"_peak_memory": 2.81,
"_peak_process_memory": "PID\tMEM\tCOMMAND\n1393\t7.16GiB\t/app/product/go/infra/anyscaled/anyscaled_/anyscaled startv2 --control_plane_url=https://console.any\n3778\t0.97GiB\t/home/ray/anaconda3/lib/python3.9/site-packages/ray/core/src/ray/gcs/gcs_server --log_dir=/tmp/ray/s\n3247\t0.42GiB\tvector --watch-config --log-format json --config-yaml /etc/vector/vector.yaml\n5319\t0.36GiB\tpython distributed/test_many_pgs.py\n600\t0.2GiB\t/app/go/infra/anyscaled/anyscaled_/anyscaled_shim --cloud_provider=aws\n4001\t0.11GiB\tray-dashboard-NodeHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import sp\n3044\t0.11GiB\t/app/go/infra/activityprobe/activityprobe ray --port=5903 --metrics_server_port=9092 --raylet_addr=l\n4486\t0.1GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/a\n3232\t0.09GiB\t/usr/bin/python3 /app/infra/dataplane/webterminal/webterminal_sidecar_image.binary.runfiles/product/\n4488\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/ru",
"_peak_memory": 2.94,
"_peak_process_memory": "PID\tMEM\tCOMMAND\n1126\t7.66GiB\t/app/product/go/infra/anyscaled/anyscaled_/anyscaled startv2 --control_plane_url=https://console.any\n3490\t1.1GiB\t/home/ray/anaconda3/lib/python3.9/site-packages/ray/core/src/ray/gcs/gcs_server --log_dir=/tmp/ray/s\n5004\t0.36GiB\tpython distributed/test_many_pgs.py\n3037\t0.34GiB\tvector --watch-config --log-format json --config-yaml /etc/vector/vector.yaml\n583\t0.19GiB\t/app/go/infra/anyscaled/anyscaled_/anyscaled_shim --cloud_provider=aws\n4206\t0.11GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/a\n3720\t0.11GiB\tray-dashboard-NodeHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import sp\n2924\t0.1GiB\t/usr/bin/python3 /app/infra/dataplane/webterminal/webterminal_sidecar_image.binary.runfiles/product/\n4208\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/ru\n3623\t0.08GiB\t/home/ray/anaconda3/bin/python3.9 /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/dash",
"num_pgs": 1000,
"perf_metrics": [
{
"perf_metric_name": "pgs_per_second",
"perf_metric_type": "THROUGHPUT",
"perf_metric_value": 12.47149444972938
"perf_metric_value": 17.897951502183457
},
{
"perf_metric_name": "dashboard_p50_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 4.935
"perf_metric_value": 4.128
},
{
"perf_metric_name": "dashboard_p95_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 11.336
"perf_metric_value": 54.16
},
{
"perf_metric_name": "dashboard_p99_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 232.641
"perf_metric_value": 1212.615
}
],
"pgs_per_second": 12.47149444972938,
"success": "1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of the success field is a good step towards standardizing the format of benchmark result files. To ensure full consistency, this field should also be removed from release/perf_metrics/scalability/single_node.json, where it is still present.

"time": 80.18285250663757
"pgs_per_second": 17.897951502183457,
"time": 55.872315883636475
}
19 changes: 9 additions & 10 deletions release/perf_metrics/benchmarks/many_tasks.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"_dashboard_memory_usage_mb": 95.678464,
"_dashboard_memory_usage_mb": 104.124416,
"_dashboard_test_success": true,
"_peak_memory": 4.01,
"_peak_process_memory": "PID\tMEM\tCOMMAND\n3780\t1.1GiB\t/home/ray/anaconda3/lib/python3.9/site-packages/ray/core/src/ray/gcs/gcs_server --log_dir=/tmp/ray/s\n5801\t0.75GiB\tpython distributed/test_many_tasks.py --num-tasks=10000\n3998\t0.48GiB\tray-dashboard-NodeHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import sp\n3294\t0.27GiB\tvector --watch-config --log-format json --config-yaml /etc/vector/vector.yaml\n4001\t0.18GiB\tray-dashboard-StateHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import s\n4493\t0.11GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/a\n1403\t0.1GiB\t/app/product/go/infra/anyscaled/anyscaled_/anyscaled startv2 --control_plane_url=https://console.any\n3184\t0.09GiB\t/usr/bin/python3 /app/infra/dataplane/webterminal/webterminal_sidecar_image.binary.runfiles/product/\n3916\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/dash\n4495\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/_private/ru",
"_peak_memory": 6.24,
"_peak_process_memory": "PID\tMEM\tCOMMAND\n3751\t2.0GiB\tray-dashboard-NodeHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import sp\n3524\t1.95GiB\t/home/ray/anaconda3/lib/python3.9/site-packages/ray/core/src/ray/gcs/gcs_server --log_dir=/tmp/ray/s\n5011\t0.76GiB\tpython distributed/test_many_tasks.py --num-tasks=10000\n3015\t0.27GiB\tvector --watch-config --log-format json --config-yaml /etc/vector/vector.yaml\n582\t0.19GiB\t/app/go/infra/anyscaled/anyscaled_/anyscaled_shim --cloud_provider=aws\n1163\t0.11GiB\t/app/product/go/infra/anyscaled/anyscaled_/anyscaled startv2 --control_plane_url=https://console.any\n3754\t0.11GiB\tray-dashboard-StateHead-0 (/home/ray/anaconda3/bin/python3.9 -c \"from multiprocessing.spawn import s\n4237\t0.11GiB\t/home/ray/anaconda3/bin/python3.9 -u /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/a\n3147\t0.1GiB\t/usr/bin/python3 /app/infra/dataplane/webterminal/webterminal_sidecar_image.binary.runfiles/product/\n3654\t0.09GiB\t/home/ray/anaconda3/bin/python3.9 /home/ray/anaconda3/lib/python3.9/site-packages/ray/dashboard/dash",
"num_tasks": 10000,
"perf_metrics": [
{
"perf_metric_name": "tasks_per_second",
"perf_metric_type": "THROUGHPUT",
"perf_metric_value": 368.5098005212305
"perf_metric_value": 571.2270630108624
},
{
"perf_metric_name": "used_cpus_by_deadline",
Expand All @@ -18,21 +18,20 @@
{
"perf_metric_name": "dashboard_p50_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 6.4
"perf_metric_value": 6.284
},
{
"perf_metric_name": "dashboard_p95_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 487.355
"perf_metric_value": 947.76
},
{
"perf_metric_name": "dashboard_p99_latency_ms",
"perf_metric_type": "LATENCY",
"perf_metric_value": 749.022
"perf_metric_value": 3041.184
}
],
"success": "1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

I notice the success field is being removed, which helps in making the benchmark result files more consistent. For complete consistency, this field should also be removed from release/perf_metrics/scalability/single_node.json.

"tasks_per_second": 368.5098005212305,
"time": 327.1363203525543,
"tasks_per_second": 571.2270630108624,
"time": 317.5061733722687,
"used_cpus": 2500.0
}
2 changes: 1 addition & 1 deletion release/perf_metrics/metadata.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"release_version": "2.50.0"}
{"release_version": "2.51.0"}
Loading